Configure PostgreSQL ssl by default #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only used when clientcert = 1 in pg_hba.conf We never set clientcert so we don't need this. ref: https://www.postgresql.org/docs/9.5/static/ssl-tcp.html
…ript This will allow us to generate new postgres certs with the following command: NEW_CERT_FILE=/var/www/miq/vmdb/certs/postgres.crt \ NEW_KEY_FILE=/var/www/miq/vmdb/certs/postgres.key \ generate_miq_server_cert.sh
There is no reason we can't use the default location
|
Should be merged with ManageIQ/manageiq-appliance_console#22 |
|
Checked commits carbonin/manageiq-appliance@2ee33b1~...afd8e04 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Dec 15, 2017
Configure PostgreSQL ssl by default (cherry picked from commit c64f84a)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to use
generate_miq_server_cert.shfor generating certs in arbitrary locations by providing theNEW_CERT_FILEandNEW_KEY_FILEenvironment variables.It also removes the conditional logic around using ssl in the postgres configuration files.
We will now generate certs in the default location when initializing the database so we will always set
ssltoon, can remove the erb from pg_hba.conf and no-longer need to specify alternate cert locations.