Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HAMMER] Update dependency on manageiq-appliance_console #245

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jul 9, 2019

@bdunne bdunne requested a review from simaishi July 9, 2019 21:06
@miq-bot miq-bot changed the title Update dependency on manageiq-appliance_console [HAMMER] Update dependency on manageiq-appliance_console Jul 9, 2019
@carbonin
Copy link
Member

carbonin commented Jul 9, 2019

This only fixes https://bugzilla.redhat.com/show_bug.cgi?id=1720223, right? Not https://bugzilla.redhat.com/show_bug.cgi?id=1716404 since that is RHEL 8 specific?

@carbonin
Copy link
Member

carbonin commented Jul 9, 2019

Ah, just saw the commit message. 👍

@carbonin
Copy link
Member

@bdunne this also fixes https://bugzilla.redhat.com/show_bug.cgi?id=1728403, can you add that to the commit message as well?

@miq-bot
Copy link
Member

miq-bot commented Jul 10, 2019

Checked commit bdunne@c2d302c with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@simaishi simaishi merged commit 36f18f4 into ManageIQ:hammer Jul 22, 2019
@simaishi simaishi added this to the Sprint 116 Ending Jul 22, 2019 milestone Jul 22, 2019
@simaishi simaishi added the bug label Jul 22, 2019
@bdunne bdunne deleted the hammer_pr_244 branch July 22, 2019 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants