Only start evmserverd after db and messaging config #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
only_start_evmserverd_after_db_and_messaging_config
branch
from
2d9bae0
to
41aa311
Compare
1 task
|
Merged #194 , so this can be rebased. |
agrare
force-pushed
the
only_start_evmserverd_after_db_and_messaging_config
branch
5 times, most recently
from
674f480
to
b5a09c1
Compare
agrare
changed the title
Fryguy
reviewed
Oct 14, 2022
bin/appliance_console
Outdated
| no_changes = database_action == "no_changes" && messaging_action == "no_changes" | ||
|
|
||
| # Stop evmserver while we make changes to the database and/or messaging configuration | ||
| unless no_changes |
There was a problem hiding this comment.
The double negative is killing me 😆
Fryguy
reviewed
Oct 14, 2022
bin/appliance_console
Outdated
| @@ -393,6 +393,14 @@ Static Network Configuration | |||
|
|
|||
| messaging_action = ask_with_menu("Configure Messaging", messaging_options) | |||
|
|
|||
| no_changes = database_action == "no_changes" && messaging_action == "no_changes" | |||
There was a problem hiding this comment.
Perhaps, instead we make it a positive variable?
Suggested change
| no_changes = database_action == "no_changes" && messaging_action == "no_changes" | |
| changes_requested = database_action != "no_changes" || messaging_action != "no_changes" |
There was a problem hiding this comment.
Or
Suggested change
| no_changes = database_action == "no_changes" && messaging_action == "no_changes" | |
| changes_requested = !(database_action == "no_changes" && messaging_action == "no_changes") |
agrare
force-pushed
the
only_start_evmserverd_after_db_and_messaging_config
branch
from
b5a09c1
to
ce9ab16
Compare
Currently when configuring the application evmserverd is started after setting up the database, it is then restarted twice after configuring messaging (once for unconfiguring then once after configuring). This is very inefficient and when we move to require messaging to be configured in order to start evmserverd then the first start won't ever complete anyway.
agrare
force-pushed
the
only_start_evmserverd_after_db_and_messaging_config
branch
from
ce9ab16
to
4d634e3
Compare
|
Checked commits agrare/manageiq-appliance_console@2f0b91d~...4d634e3 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
agrare
added a commit
to agrare/manageiq-appliance_console
that referenced
this pull request
Oct 18, 2022
Fixed - Don't require pressing any key twice for message configuration (ManageIQ#193) Added - Report messaging configuration on summary info page (ManageIQ#190) Changed - Refactor EvmServer operations (ManageIQ#194) - Only start evmserverd after all application configuration is done (ManageIQ#195) - Don't start evmserverd until messaging is configured (ManageIQ#196)
agrare
added a commit
to agrare/manageiq-appliance_console
that referenced
this pull request
Oct 19, 2022
Fixed - Don't require pressing any key twice for message configuration (ManageIQ#193) Added - Report messaging configuration on summary info page (ManageIQ#190) Changed - Refactor EvmServer operations (ManageIQ#194) - Only start evmserverd after all application configuration is done (ManageIQ#195) - **BREAKING** Don't start evmserverd until messaging is configured (ManageIQ#196)
agrare
added a commit
to agrare/manageiq-appliance_console
that referenced
this pull request
Oct 19, 2022
Breaking - Don't start evmserverd until messaging is configured (ManageIQ#196) Fixed - Don't require pressing any key twice for message configuration (ManageIQ#193) Added - Report messaging configuration on summary info page (ManageIQ#190) Changed - Refactor EvmServer operations (ManageIQ#194) - Only start evmserverd after all application configuration is done (ManageIQ#195)
agrare
added a commit
to agrare/manageiq-appliance_console
that referenced
this pull request
Oct 19, 2022
Breaking - Don't start evmserverd until messaging is configured (ManageIQ#196) Fixed - Don't require pressing any key twice for message configuration (ManageIQ#193) Added - Report messaging configuration on summary info page (ManageIQ#190) Changed - Refactor EvmServer operations (ManageIQ#194) - Only start evmserverd after all application configuration is done (ManageIQ#195)
agrare
added a commit
to agrare/manageiq-appliance_console
that referenced
this pull request
Oct 19, 2022
Breaking - Don't start evmserverd until messaging is configured (ManageIQ#196) Fixed - Don't require pressing any key twice for message configuration (ManageIQ#193) Added - Report messaging configuration on summary info page (ManageIQ#190) Changed - Refactor EvmServer operations (ManageIQ#194) - Only start evmserverd after all application configuration is done (ManageIQ#195)
agrare
deleted the
only_start_evmserverd_after_db_and_messaging_config
branch
agrare
added a commit
to agrare/manageiq-appliance_console
that referenced
this pull request
Oct 20, 2022
Fixed - Don't require pressing any key twice for message configuration (ManageIQ#193) Added - Report messaging configuration on summary info page (ManageIQ#190) Changed - Refactor EvmServer operations (ManageIQ#194) - Only start evmserverd after all application configuration is done (ManageIQ#195) - Don't start evmserverd until messaging is configured **BREAKING** (ManageIQ#196) - Simplify messaging options by saving in yml files (ManageIQ#197)
agrare
added a commit
to agrare/manageiq-appliance_console
that referenced
this pull request
Oct 20, 2022
Fixed - Don't require pressing any key twice for message configuration (ManageIQ#193) Added - Report messaging configuration on summary info page (ManageIQ#190) Changed - Refactor EvmServer operations (ManageIQ#194) - Only start evmserverd after all application configuration is done (ManageIQ#195) - **BREAKING** Don't start evmserverd until messaging is configured **BREAKING** (ManageIQ#196) - Simplify messaging options by saving in yml files (ManageIQ#197)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring the application there are possibly two steps, setting up the database and setting up messaging.
Each sub-section was stopping/starting/restarting evmserverd on its own so if you went through and configured the database and messaging we were starting evmserver after the database was setup, restarting it after clearing default messaging config (side-note I feel like we should start from a cleared state when we build the appliance), then restarting it again after completing messaging setup.
This changes the behavior to stop evmserverd if changes are going to be made to either the database or messaging, then starting it again after it completes.
Depends on: