Don't start evmserverd if messaging is not configured #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
agrare
force-pushed
the
dont_start_evmserverd_if_messaging_not_configured
branch
from
51c2070
to
0fab933
Compare
Fryguy
reviewed
Oct 13, 2022
Comment on lines
20
to
22
| say e.result.output | ||
| say e.result.error | ||
| say "" |
There was a problem hiding this comment.
where is say defined? or is it a global method?
There was a problem hiding this comment.
I see this used everywhere, can check where it is defined though
There was a problem hiding this comment.
I assume it comes from highline globally.
|
Love the refactoring, but wondering if that should be a separate PR? I'm having trouble separating the refactor from the "Dont start evmserverd if messaging not configured" |
|
Oh nvm, I didn't see that the "depends on" actually was "built on" (I assumed it was an independent PR). |
agrare
changed the title
agrare
force-pushed
the
dont_start_evmserverd_if_messaging_not_configured
branch
8 times, most recently
from
00d4abb
to
19c4f04
Compare
|
#195 is merged |
agrare
force-pushed
the
dont_start_evmserverd_if_messaging_not_configured
branch
from
19c4f04
to
c3dff5a
Compare
Fryguy
reviewed
Oct 17, 2022
agrare
commented
Oct 17, 2022
Comment on lines
-190
to
-195
| def configure_messaging_type(value) | ||
| say(__method__.to_s.tr("_", " ").titleize) | ||
|
|
||
| ManageIQ::ApplianceConsole::Utilities.rake_run!("evm:settings:set", ["/prototype/messaging_type=#{value}"]) | ||
| end | ||
|
|
There was a problem hiding this comment.
NOTE this will be the default (once ManageIQ/manageiq#21997 is merged) and will not need to be set by appliance console
agrare
force-pushed
the
dont_start_evmserverd_if_messaging_not_configured
branch
from
9b6a8d4
to
1327aca
Compare
|
Checked commits agrare/manageiq-appliance_console@c3dff5a~...1327aca with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
agrare
changed the title
|
Okay ran a live test setting up an appliance and works as expected, taking out of WIP |
agrare
added a commit
to agrare/manageiq-appliance_console
that referenced
this pull request
Oct 18, 2022
Fixed - Don't require pressing any key twice for message configuration (ManageIQ#193) Added - Report messaging configuration on summary info page (ManageIQ#190) Changed - Refactor EvmServer operations (ManageIQ#194) - Only start evmserverd after all application configuration is done (ManageIQ#195) - Don't start evmserverd until messaging is configured (ManageIQ#196)
agrare
added a commit
to agrare/manageiq-appliance_console
that referenced
this pull request
Oct 19, 2022
Fixed - Don't require pressing any key twice for message configuration (ManageIQ#193) Added - Report messaging configuration on summary info page (ManageIQ#190) Changed - Refactor EvmServer operations (ManageIQ#194) - Only start evmserverd after all application configuration is done (ManageIQ#195) - **BREAKING** Don't start evmserverd until messaging is configured (ManageIQ#196)
agrare
added a commit
to agrare/manageiq-appliance_console
that referenced
this pull request
Oct 19, 2022
Breaking - Don't start evmserverd until messaging is configured (ManageIQ#196) Fixed - Don't require pressing any key twice for message configuration (ManageIQ#193) Added - Report messaging configuration on summary info page (ManageIQ#190) Changed - Refactor EvmServer operations (ManageIQ#194) - Only start evmserverd after all application configuration is done (ManageIQ#195)
agrare
added a commit
to agrare/manageiq-appliance_console
that referenced
this pull request
Oct 19, 2022
Breaking - Don't start evmserverd until messaging is configured (ManageIQ#196) Fixed - Don't require pressing any key twice for message configuration (ManageIQ#193) Added - Report messaging configuration on summary info page (ManageIQ#190) Changed - Refactor EvmServer operations (ManageIQ#194) - Only start evmserverd after all application configuration is done (ManageIQ#195)
agrare
added a commit
to agrare/manageiq-appliance_console
that referenced
this pull request
Oct 19, 2022
Breaking - Don't start evmserverd until messaging is configured (ManageIQ#196) Fixed - Don't require pressing any key twice for message configuration (ManageIQ#193) Added - Report messaging configuration on summary info page (ManageIQ#190) Changed - Refactor EvmServer operations (ManageIQ#194) - Only start evmserverd after all application configuration is done (ManageIQ#195)
agrare
added a commit
to agrare/manageiq-appliance_console
that referenced
this pull request
Oct 20, 2022
Fixed - Don't require pressing any key twice for message configuration (ManageIQ#193) Added - Report messaging configuration on summary info page (ManageIQ#190) Changed - Refactor EvmServer operations (ManageIQ#194) - Only start evmserverd after all application configuration is done (ManageIQ#195) - Don't start evmserverd until messaging is configured **BREAKING** (ManageIQ#196) - Simplify messaging options by saving in yml files (ManageIQ#197)
agrare
added a commit
to agrare/manageiq-appliance_console
that referenced
this pull request
Oct 20, 2022
Fixed - Don't require pressing any key twice for message configuration (ManageIQ#193) Added - Report messaging configuration on summary info page (ManageIQ#190) Changed - Refactor EvmServer operations (ManageIQ#194) - Only start evmserverd after all application configuration is done (ManageIQ#195) - **BREAKING** Don't start evmserverd until messaging is configured **BREAKING** (ManageIQ#196) - Simplify messaging options by saving in yml files (ManageIQ#197)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only start evmserverd once database and messaging have been configured
NOTE added a third state to
ManageIQ Server:running, not running, not configuredso it is consistent with the database statusDepends on:
Required for: