fix cli set timezone doesn't work #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add-label wip |
miq-bot
changed the title
|
@miq-bot remove-label wip |
miq-bot
changed the title
carbonin
suggested changes
Dec 4, 2017
| @@ -112,6 +112,6 @@ def configure_date_time | |||
| logger.error("Failed to apply time configuration: #{e.message}") | |||
| false | |||
| end | |||
| end # class TimezoneConfiguration | |||
| end # class DateTimeConfiguration | |||
| @@ -8,8 +8,9 @@ class TimezoneConfiguration | |||
| attr_reader :current_timzone | |||
| attr_accessor :new_timezone | |||
|
|
|||
| def initialize(region_timezone_string) | |||
| def initialize(region_timezone_string, region_new_timezone_string = "") | |||
There was a problem hiding this comment.
Instead of adding a parameter here, couldn't the cli just set the new_timzone using the attr_accessor?
Then in a follow up maybe we can remove the current timezone from the parameter here because it doesn't seem to be used.
ailisp
force-pushed
the
cli-set-timezone
branch
from
81987f8
to
36e14e2
Compare
|
Checked commits ailisp/manageiq-appliance_console@36e14e2~...bf3f65c with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
carbonin
approved these changes
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Set timezone in cli doesn't work, because the new timezone parameter isn't sent to
TimezoneConfigurationclass. It's fixed now.BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1517897
\cc @carbonin, @yrudman, @gtanzillo
@miq-bot add-label bug