Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to redhat VM for set_memory and set_number_of_cpus #216

Merged
merged 2 commits into from
Aug 30, 2018
Merged

Add support to redhat VM for set_memory and set_number_of_cpus #216

merged 2 commits into from
Aug 30, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 28, 2018 •
edited by ghost
Loading

VMware provider has support to set memory and number of CPUs from Automate code. This PR add support for the same methods to oVirt provider.

Depends on: ManageIQ/manageiq-providers-ovirt#280
Associated RHZ: https://bugzilla.redhat.com/show_bug.cgi?id=1623021

@ghost
Copy link
Author

ghost commented Aug 28, 2018

@miq-bot add-label enhancement, gaprindashvili/yes

@ghost ghost mentioned this pull request Aug 28, 2018
Merged
@miq-bot
Copy link
Member

miq-bot commented Aug 28, 2018

Checked commits fabiendupont/manageiq-automation_engine@7ceb347~...bbf51f7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@gmcculloug gmcculloug self-assigned this Aug 28, 2018
gmcculloug
gmcculloug approved these changes Aug 28, 2018
View reviewed changes
Copy link
Member

@gmcculloug gmcculloug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failures are unrelated to these PR changes.

@ghost
Copy link
Author

ghost commented Aug 28, 2018

@miq-bot add-label wip

@miq-bot miq-bot changed the title Add support to redhat VM for set_memory and set_number_of_cpus [WIP] Add support to redhat VM for set_memory and set_number_of_cpus Aug 28, 2018
@miq-bot miq-bot added the wip label Aug 28, 2018
@ghost
Copy link
Author

ghost commented Aug 28, 2018

@miq-bot remove-label wip

@miq-bot miq-bot changed the title [WIP] Add support to redhat VM for set_memory and set_number_of_cpus Add support to redhat VM for set_memory and set_number_of_cpus Aug 28, 2018
@miq-bot miq-bot removed the wip label Aug 28, 2018
@ghost ghost mentioned this pull request Aug 30, 2018
Merged
@gmcculloug gmcculloug merged commit bef5fc5 into ManageIQ:master Aug 30, 2018
@gmcculloug gmcculloug added this to the Sprint 94 Ending Sept 10, 2018 milestone Aug 30, 2018
@ghost ghost deleted the redhat_vm_add_support_for_set_memory_and_cpus branch August 30, 2018 12:16
simaishi pushed a commit that referenced this pull request Sep 17, 2018
@gmcculloug @simaishi
Merge pull request #216 from fdupont-redhat/redhat_vm_add_support_for…
a592927 
…_set_memory_and_cpus

Add support to redhat VM for set_memory and set_number_of_cpus
(cherry picked from commit bef5fc5)

https://bugzilla.redhat.com/show_bug.cgi?id=1629126
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit a592927ce77f5cd5c78e16ba515d3afb5f715125
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Thu Aug 30 08:12:06 2018 -0400

    Merge pull request #216 from fdupont-redhat/redhat_vm_add_support_for_set_memory_and_cpus
    
    Add support to redhat VM for set_memory and set_number_of_cpus
    (cherry picked from commit bef5fc5e930ecc9b77f6b829f914c8948eaa0c3f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1629126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmcculloug gmcculloug

Labels
blocker enhancement gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miq-bot @simaishi @gmcculloug @fabiendupont