Add support to apply right-size recommendation during transformation

[ghost]

When migrating a virtual machine, we have the opportunity to apply right-size recommendation as it is shutdown in the migration process. This brings the additional ability to shrink the target environment and lower the TCO.

Depends on:

• Add support to redhat VM for set_memory and set_number_of_cpus manageiq-automation_engine#216
• ManageIQ/manageiq-content#418

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1623072

[ghost]

@miq-bot add-label transformation, enhancement, gaprindashvili/yes, blocker

[ghost]

@miq-bot add-reviewer mkanoor

[gmcculloug]

@fdupont-redhat @bthurber I'm removing the blocker label for now as the associated BZ and dependent PRs (and their BZ) are currently not marked with the blocker label.

If this is truly a blocker fix then please set the flag on the BZs, update the dependent PRs and then we can reset here. Thanks.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[JPrause]

@miq-bot add_label blocker

[JPrause]

@gmcculloug just saw your note about the blocker flag. Let me know if this should be removed (again),..however the BZ does have the blocker flag.

[gmcculloug]

@JPrause The blocker flag was added to the BZ on 08-31 which was the day after I commented on it here, so it is legit now.

[gmcculloug]

@fdupont-redhat If you are doing an expensive lookup it is better to store this value into a variable where you can give it a more meaningful name.

Minor change, but I would suggest using:

RIGHT_SIZE_ITEMS.each do |item|
  right_size_strategy = @task.get_option("right_size_strategy_#{item}".to_sym)
  send("apply_right_size_#{item}", right_size_strategy) if right_size_strategy
end

[miq-bot]

Checked commits fabiendupont/manageiq-content@73b22c7~...a0587ca with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

content/automate/ManageIQ/Transformation/Infrastructure/VM/Common.class/methods/applyrightsize.rb

• ❗ - Line 30, Col 15 - Style/RescueStandardError - Avoid rescuing without specifying an error class.

[simaishi]

Hammer backport details:

$ git log -1
commit e1affb42bcadf96c0ff5d1d0d82cb6a992cfb98f
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Fri Sep 28 09:49:58 2018 -0400

    Merge pull request #417 from fdupont-redhat/v2v_apply_right_size
    
    Add support to apply right-size recommendation during transformation
    
    (cherry picked from commit 4f98a7855105eee49e8fe8373cbff98d6ebf2dbe)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1623072

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit fc0936e426991e4877a8cb8e1baea28fcb5006d0
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Fri Sep 28 09:49:58 2018 -0400

    Merge pull request #417 from fdupont-redhat/v2v_apply_right_size
    
    Add support to apply right-size recommendation during transformation
    
    (cherry picked from commit 4f98a7855105eee49e8fe8373cbff98d6ebf2dbe)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1634834

[simaishi]

Reverted the Gaprindashvili backport.

$ git log -1
commit 814b21775347b0cbd4c4a960a51be48169c64ac1 (HEAD -> gaprindashvili, origin/gaprindashvili)
Author: Satoe Imaishi <simaishi@redhat.com>
Date:   Wed Oct 10 10:07:36 2018 -0400

    Revert "Merge pull request #417 from fdupont-redhat/v2v_apply_right_size"
    
    This reverts commit fc0936e426991e4877a8cb8e1baea28fcb5006d0.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1634834