Get the current user if user context is set. #86
Conversation
There was a problem hiding this comment.
If you want the Queue worker to run the job in a users context you would have to set the user, group,tenant in the q_options
https://github.com/lfu/manageiq-automation_engine/blob/41f94ee0a43c2a023448a82383e7228714f43c7c/lib/miq_automation_engine/engine/miq_ae_event.rb#L124
lfu
force-pushed
the
event_current_user
branch
2 times, most recently
from
8b746af
to
a08fd48
Compare
| @@ -115,13 +115,16 @@ def self.process_result(ae_result, aevent) | |||
| end | |||
|
|
|||
| def self.call_automate(obj, attrs, instance_name, options = {}) | |||
| user = obj.tenant_identity | |||
| user = User.current_user || obj.tenant_identity | |||
There was a problem hiding this comment.
@lfu @gmcculloug
When these events are raised and if the user is part of multiple groups which group should get used. Do we record the group with the events or vm ownership?
There was a problem hiding this comment.
@mkanoor The user and the group is recorded in the Queue when the event is raised. Then the user is set to the group in the memory when the item get dequeued and processed.
spec/miq_ae_event_spec.rb
Outdated
| @@ -124,6 +124,14 @@ | |||
|
|
|||
| MiqAeEvent.raise_evm_event("vm_create", vm, :vm => vm) | |||
| end | |||
|
|
|||
| it "has current user" do | |||
| User.current_user = user | |||
There was a problem hiding this comment.
@lfu use User.with_user similar to https://github.com/ManageIQ/manageiq/blob/b978b61737bf8bffcca23ab3710500b1f677d4fe/spec/lib/rbac/filterer_spec.rb#L242
This we we dont have it set for the whole thread.
When sending events to automate, use the user context if it is available. https://bugzilla.redhat.com/show_bug.cgi?id=1487749
lfu
force-pushed
the
event_current_user
branch
from
a08fd48
to
d6d39bb
Compare
|
Checked commit lfu@d6d39bb with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@mkanoor Please review. |
PR ManageIQ/manageiq#16089 allows the user_id/group_id/tenant_id to be recorded in the Queue and sets the user context when dispatching the item from the Queue.
This PR would use the user context if it is available when sending events to automate.
Blocks ManageIQ/manageiq#16179.
https://bugzilla.redhat.com/show_bug.cgi?id=1487749
cc @mkanoor