Store the event initiator in MiqEvent object. #16179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfu
force-pushed
the
miq_event_user_1487749
branch
2 times, most recently
from
1889933
to
344cdf0
Compare
|
Test failure is due to the dependency on ManageIQ/manageiq-automation_engine#86. |
lfu
force-pushed
the
miq_event_user_1487749
branch
from
344cdf0
to
eecbdec
Compare
mkanoor
reviewed
Oct 27, 2017
| @@ -11,16 +11,20 @@ def process_tasks(options) | |||
| task_audit_event(:success, options, :message => msg) | |||
| else | |||
| assert_known_task(options) | |||
| options[:userid] ||= "system" | |||
| options[:userid] = User.current_user.try(:userid) || "system" | |||
There was a problem hiding this comment.
@lfu
Won't this override the options[:userid] if it exists? Backward compatibility
lfu
force-pushed
the
miq_event_user_1487749
branch
from
eecbdec
to
940e569
Compare
|
Checked commit lfu@940e569 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
lfu
added a commit
to lfu/manageiq-providers-amazon
that referenced
this pull request
Oct 27, 2017
lfu
added a commit
to lfu/manageiq
that referenced
this pull request
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep the info about the event initiator in the MiqEvent object.
Depends on ManageIQ/manageiq-automation_engine#86.
Depends on ManageIQ/manageiq-schema#94.
https://bugzilla.redhat.com/show_bug.cgi?id=1487749
@miq-bot assign @gmcculloug
@miq-bot add_label enhancement