Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2v: Rephrase ISO driver selection #169

Merged
merged 1 commit into from
Aug 10, 2017
Merged

Conversation

matobet
Copy link
Contributor

@matobet matobet commented Aug 10, 2017

@matobet
Copy link
Contributor Author

matobet commented Aug 10, 2017

@miq-bot assign @tinaafitz

@matobet
Copy link
Contributor Author

matobet commented Aug 10, 2017

@miq-bot add_label fine/yes

@gmcculloug
Copy link
Member

@matobet You need to update the test to match the updated string. It also looks like different items are coming back for the iso_images.

@miq-bot
Copy link
Member

miq-bot commented Aug 10, 2017

Checked commit matobet@1564669 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@gmcculloug gmcculloug merged commit 3ecab13 into ManageIQ:master Aug 10, 2017
@gmcculloug gmcculloug added this to the Sprint 67 Ending Aug 21, 2017 milestone Aug 10, 2017
simaishi pushed a commit that referenced this pull request Aug 11, 2017
v2v: Rephrase ISO driver selection
(cherry picked from commit 3ecab13)

https://bugzilla.redhat.com/show_bug.cgi?id=1480586
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit aabe6e5b9bca089369c7cc2deb8f03a66cafd29c
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Thu Aug 10 11:04:43 2017 -0400

    Merge pull request #169 from matobet/master
    
    v2v: Rephrase ISO driver selection
    (cherry picked from commit 3ecab134beeab427d2d97b5c80457244f0d2ac65)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1480586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants