v2v: Pre-check install_drivers checkbox for windows VMs #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matobet
force-pushed
the
dynamic-windows
branch
4 times, most recently
from
e3000e3
to
7aedd41
Compare
|
@miq-bot add_label fine/yes |
|
@miq-bot assign @gmcculloug |
matobet
changed the title
|
@matobet PR ManageIQ/manageiq#15810 is merged, if you unwip we can merge this. |
matobet
changed the title
|
@miq-bot remove_label wip |
gmcculloug
reviewed
Aug 15, 2017
|
|
||
| def main | ||
| os = @handle.root['vm'].operating_system | ||
| is_windows = os && os.product_name =~ /windows/i |
There was a problem hiding this comment.
@matobet Minor, but you could use try here: os.try(:product_name) =~ /windows/i
matobet
force-pushed
the
dynamic-windows
branch
from
7aedd41
to
0ecf8e9
Compare
|
Checked commit matobet@0ecf8e9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@gmcculloug done |
mkanoor
approved these changes
Aug 30, 2017
|
@simaishi could you please backport this? |
|
@jelkosz Since this isn't a blocker for the release we're currently working on, I'll backport once we start working on the next release. |
simaishi
pushed a commit
that referenced
this pull request
Nov 14, 2017
v2v: Pre-check install_drivers checkbox for windows VMs (cherry picked from commit efd5d06) https://bugzilla.redhat.com/show_bug.cgi?id=1512955
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on fix to
Dialog#init_fields_with_values(PR ManageIQ/manageiq#15810)Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1472843