Fix for custom button not passing target object to dynamic dialog fields #15810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclarizio
force-pushed
the
fix_for_nil_dialog
branch
from
3096ead
to
f8f29e8
Compare
eclarizio
changed the title
miq-bot
changed the title
|
Checked commit eclarizio@f8f29e8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
eclarizio
changed the title
|
Found while working on PR ManageIQ/manageiq-content#170 |
simaishi
pushed a commit
that referenced
this pull request
Aug 23, 2017
Fix for custom button not passing target object to dynamic dialog fields (cherry picked from commit ad6fdb6) https://bugzilla.redhat.com/show_bug.cgi?id=1484539
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
Aug 23, 2017
Fix for custom button not passing target object to dynamic dialog fields (cherry picked from commit ad6fdb6) https://bugzilla.redhat.com/show_bug.cgi?id=1484541
|
Euwe backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
Fix for custom button not passing target object to dynamic dialog fields (cherry picked from commit ad6fdb6) https://bugzilla.redhat.com/show_bug.cgi?id=1484539
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running a dialog in a custom button, users were unable to get a handle to the target resource because
.valueis what calls into the automate method, but without having set.dialogon thedialog_field, it was unable to get the target resource.This fix will ensure that the dialog is set on the field before attempting to call
.value.Tagged as WIP for now until the BZ exists.https://bugzilla.redhat.com/show_bug.cgi?id=1481380
@miq-bot assign @gmcculloug
@miq-bot add_label bug, euwe/yes, fine/yes