-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typo in Service Retirement method. #189
Fixed typo in Service Retirement method. #189
Conversation
update_service_retirement_status method had incorrect step name. This caused a problem when trying to retire a service that is already in the process of being retired.
I re-created the customer problem by creating a Service Retirement Complete email and trying to retire the service 4 times in a row. With the change only 1 email was sent: |
@tinaafitz Please Review |
Checked commit billfitzgerald0120@0ccaec8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Previously discussed this issue with @tinaafitz. Change looks good. 👍 |
Fixed typo in Service Retirement method. (cherry picked from commit 5c1d10f) https://bugzilla.redhat.com/show_bug.cgi?id=1496947
Fine backport details:
|
update_service_retirement_status method had incorrect step name.
This caused a problem when trying to retire a service that is already in the process of being retired.
https://bugzilla.redhat.com/show_bug.cgi?id=1440972
@miq-bot add_label bug, services, fine/yes
@miq-bot assign @gmcculloug