Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in Service Retirement method. #189

Merged

Conversation

billfitzgerald0120
Copy link
Contributor

update_service_retirement_status method had incorrect step name.

This caused a problem when trying to retire a service that is already in the process of being retired.

https://bugzilla.redhat.com/show_bug.cgi?id=1440972

@miq-bot add_label bug, services, fine/yes
@miq-bot assign @gmcculloug

update_service_retirement_status method had incorrect step name.

This caused a problem when trying to retire a service that is already in the process of being retired.
@billfitzgerald0120
Copy link
Contributor Author

I re-created the customer problem by creating a Service Retirement Complete email and trying to retire the service 4 times in a row.
Without the change 4 emails were sent :
[----] I, [2017-09-22T10:48:00.986676 #76788:3fcc722266bc] INFO -- : Sending email to evmadmin@example.com from evmadmin@example.com subject:
[----] I, [2017-09-22T10:48:18.335278 #76788:3fcc7266b4fc] INFO -- : Sending email to evmadmin@example.com from evmadmin@example.com subject:
[----] I, [2017-09-22T10:51:37.945849 #76788:3fcc75040ac0] INFO -- : Sending email to evmadmin@example.com from evmadmin@example.com subject:
[----] I, [2017-09-22T10:52:48.356761 #80331:3fcc723c20c0] INFO -- : Sending email to evmadmin@example.com from evmadmin@example.com subject:

With the change only 1 email was sent:
[----] I, [2017-09-22T11:09:57.171425 #80331:3fcc72abb78c] INFO -- : Sending email to evmadmin@example.com from evmadmin@example.com subject:

@billfitzgerald0120
Copy link
Contributor Author

@tinaafitz Please Review

@miq-bot
Copy link
Member

miq-bot commented Sep 22, 2017

Checked commit billfitzgerald0120@0ccaec8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@gmcculloug
Copy link
Member

Previously discussed this issue with @tinaafitz. Change looks good. 👍

@gmcculloug gmcculloug merged commit 5c1d10f into ManageIQ:master Sep 22, 2017
@gmcculloug gmcculloug added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 22, 2017
simaishi pushed a commit that referenced this pull request Nov 10, 2017
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 748594395090f25ed3304092ea386b3bc5ca78ae
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Fri Sep 22 16:47:19 2017 -0400

    Merge pull request #189 from billfitzgerald0120/service_retirement_typo
    
    Fixed typo in Service Retirement method.
    (cherry picked from commit 5c1d10ffcfe7292f3d77e5a072aeab7221ce21f4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1496947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants