Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change VMware URI to connect directly to ESXi #405

Merged
merged 2 commits into from
Aug 20, 2018
Merged

Change VMware URI to connect directly to ESXi #405

merged 2 commits into from
Aug 20, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 17, 2018 •
edited by ghost
Loading

While investigating issues with large transformations in parallel, it was identified that vCenter is a bottleneck for VM transformation. The solution is to connect directly to the ESXi host. This PR provides the necessary changes to Automate, in order to connect to the ESXi host.

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1618717

@ghost
Copy link
Author

ghost commented Aug 17, 2018

@miq-bot add-labels transformation, enhancement, gaprindashvili/yes, blocker

gmcculloug
gmcculloug reviewed Aug 17, 2018
View reviewed changes
content/automate/ManageIQ/Transformation/TransformationHosts/Common.class/__methods__/utils.rb Outdated
vmware_uri = "vpx://"
vmware_uri += "#{source_ems.authentication_userid.gsub('@', '%40')}@#{source_ems.hostname}/"
vmware_uri = "esx://"
vmware_uri += "root@#{source_vm.host.ipaddress}/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok to always use root? I believe that can be disabled on ESX. Will this be noted as a requirement?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

root user is always enabled on the ESXi host when using the API. It's not the SSH connection.

@gmcculloug gmcculloug self-assigned this Aug 17, 2018
@gmcculloug
Copy link
Member

@fdupont-redhat Is this the only PR required to resolved the BZ?

@miq-bot
Copy link
Member

miq-bot commented Aug 17, 2018

Checked commits fabiendupont/manageiq-content@521867a~...31f843b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Rubocop - Linter::Rubocop STDERR:
502 "Bad Gateway"
/opt/rubies/ruby-2.3.3/lib/ruby/2.3.0/net/http/response.rb:120:in `error!'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/remote_config.rb:63:in `handle_response'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/remote_config.rb:51:in `request'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/remote_config.rb:21:in `file'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/config_loader.rb:33:in `load_file'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/config_loader_resolver.rb:87:in `block in base_configs'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/config_loader_resolver.rb:86:in `map'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/config_loader_resolver.rb:86:in `base_configs'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/config_loader_resolver.rb:21:in `resolve_inheritance'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/config_loader.rb:44:in `load_file'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/config_loader.rb:79:in `configuration_from_file'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/config_store.rb:44:in `for'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/target_finder.rb:161:in `excluded_dirs'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/target_finder.rb:139:in `find_files'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/target_finder.rb:112:in `target_files_in_dir'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/target_finder.rb:83:in `find'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/runner.rb:58:in `find_target_files'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/runner.rb:34:in `run'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/cli.rb:150:in `execute_runner'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/cli.rb:78:in `execute_runners'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/lib/rubocop/cli.rb:38:in `run'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/bin/rubocop:13:in `block in <top (required)>'
/opt/rubies/ruby-2.3.3/lib/ruby/2.3.0/benchmark.rb:308:in `realtime'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/rubocop-0.52.1/bin/rubocop:12:in `<top (required)>'
/opt/rubies/ruby-2.3.3/bin/rubocop:22:in `load'
/opt/rubies/ruby-2.3.3/bin/rubocop:22:in `<main>'

@nyoxi
Copy link

nyoxi commented Aug 17, 2018

LGTM

@ghost ghost changed the title Change VMware URI to connect directly to ESXi [WIP] Change VMware URI to connect directly to ESXi Aug 17, 2018
@miq-bot miq-bot added the wip label Aug 17, 2018
@ghost
Copy link
Author

ghost commented Aug 17, 2018

@miq-bot remove-label wip

@miq-bot miq-bot changed the title [WIP] Change VMware URI to connect directly to ESXi Change VMware URI to connect directly to ESXi Aug 17, 2018
@miq-bot miq-bot removed the wip label Aug 17, 2018
@gmcculloug gmcculloug merged commit 154c82f into ManageIQ:master Aug 20, 2018
@gmcculloug gmcculloug added this to the Sprint 93 Ending Aug 27, 2018 milestone Aug 20, 2018
@ghost ghost deleted the v2v_change_vmware_uri branch August 21, 2018 16:14
@ghost ghost mentioned this pull request Sep 13, 2018
Merged
simaishi pushed a commit that referenced this pull request Sep 17, 2018
@gmcculloug @simaishi
Merge pull request #405 from fdupont-redhat/v2v_change_vmware_uri
25f3a0a 
Change VMware URI to connect directly to ESXi
(cherry picked from commit 154c82f)

https://bugzilla.redhat.com/show_bug.cgi?id=1621441
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 25f3a0adaba7a783af7cc87aa3b5a067ce730a5b
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Mon Aug 20 19:00:51 2018 -0400

    Merge pull request #405 from fdupont-redhat/v2v_change_vmware_uri
    
    Change VMware URI to connect directly to ESXi
    (cherry picked from commit 154c82f26d6392496531e794bb2752d5c55b6c3e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1621441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmcculloug gmcculloug

Labels
blocker enhancement gaprindashvili/backported v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gmcculloug @miq-bot @nyoxi @simaishi @jrafanie @fabiendupont