Fix userid in transformation throttler launch #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add-label transformation, bug, hammer/yes |
|
Checked commit fabiendupont@5fd8107 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gmcculloug
reviewed
Oct 3, 2018
| it "with default values" do | ||
| allow(ae_service).to receive(:vmdb).with(:user).and_return(svc_vmdb_handle) | ||
| allow(svc_vmdb_handle).to receive(:find_by).with(:userid => 'admin').and_return(svc_model_user) |
There was a problem hiding this comment.
You can do this with less stubbing.
Instead of a let block just replace these two allow lines with
user_admin = FactoryGirl.create(:user, :userid => 'admin')
Then update the hash below with the variable name for the user object:
:user_id => user_admin.id,
|
@fdupont-redhat Please squash that last commit and we'll be ready to merge. |
ghost
force-pushed
the
v2v_fix_admin_userid_in_throttler_launch
branch
from
9459ef1
to
9191e62
Compare
simaishi
pushed a commit
that referenced
this pull request
Oct 5, 2018
…hrottler_launch Fix userid in transformation throttler launch (cherry picked from commit 5688461) https://bugzilla.redhat.com/show_bug.cgi?id=1594196
|
Hammer backport details: |
ghost
pushed a commit
to fabiendupont/manageiq-content
that referenced
this pull request
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the existing implementation, the user_id passed to
create_automation_requestis hard coded to1. And that's obviously a bad idea. In the real world, the id of the admin user is derived from the region number, as all the ids in the VMDB.A constant information is that the
useridisadmin, so it allows to retrieve the correct user object from the VMDB and use its id instead of1. This PR implements that change.Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1594196