[V2V] Remove check of task.options[:collapse_snapshots] #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add-label transformation, bug, ivanchuk/yes, blocker |
|
Checked commit fabiendupont@bde2116 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Pull Request Test Coverage Report for Build 3482
💛 - Coveralls |
mkanoor
approved these changes
Aug 22, 2019
simaishi
pushed a commit
that referenced
this pull request
Aug 23, 2019
…ion_collapse_snapshots [V2V] Remove check of task.options[:collapse_snapshots] (cherry picked from commit d2d7a4b) https://bugzilla.redhat.com/show_bug.cgi?id=1744563
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
/Transformation/Infrastructure/VM/Common/CollapseSnapshotschecks that task.options[:collapse_snapshots] is true. No code set this value so it will always fail if VM has snapshots.This PR removes the check, because snapshot removal is mandatory.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1744563