Fixes VM extend retirement

[psachin]

The retires_on field was changed from a :date column to a :datetime which now requires the days (in seconds) be added to the time.

https://bugzilla.redhat.com/show_bug.cgi?id=1427503

This issue was introduced in PR ManageIQ/manageiq#11156

[gmcculloug]

@tinaafitz @mkanoor Please review.

cc @billfitzgerald0120

[gmcculloug]

@tinaafitz Should this logic be changed to use the extend_retires_on method and is that method also broken now? app/models/mixins/retirement_mixin.rb#L54

[tinaafitz]

@psachin Thanks for the fixing the methods. We added an extend_retires_on method as mentioned by @gmcculloug. I created a PR to address the days issue there.
PR is WIP because I have to fix a few tests:
ManageIQ/manageiq#14143

Once that PR gets merged, can you change the 2 Automate methods to use the new method.
vm.extend_retires_on(vm_retire_extend_days, vm.retires_on)

cc @mkanoor @billfitzgerald0120

[psachin]

@tinaafitz Sure

[miq-bot]

Checked commit psachin@81535b3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🍰

[gmcculloug]

Merging to get fix in. @billfitzgerald0120 is working on refactoring and adding tests which will come in a followup PR.

[simaishi]

Euwe backport details:

$ git log -1
commit 647760573e46e2807718b862d4dcdc78500a1881
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Fri Mar 17 17:00:58 2017 -0400

    Merge pull request #62 from psachin/BZ#1427503
    
    Fixes VM extend retirement
    (cherry picked from commit f8add0c3bb362acf41f4607d790dbe0a2957e120)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1433980