Retirement - use datetime instead of date - migration #11156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no date columns in the db
…(or Time.now.to_date) + removed retires_on_date()
…ement set on #{retires_on}"
+- details
makes retires_on_date function useless
.in_time_zone can convert Date, Time, DateTime and String
himdel
changed the title
|
Checked commits https://github.com/himdel/manageiq/compare/298963247759838bd9eeba5cd6ad25cd0620c7eb~...f728ef10876fa68bdb7c01be96f0d69b700580e1 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 app/models/mixins/retirement_mixin.rb
spec/lib/miq_expression_spec.rb
|
|
@gmcculloug can you review please? I'd like to get this in before the migration freeze.. @dclarizio cc, should be ready (I hope..) |
psachin
pushed a commit
to psachin/manageiq-content
that referenced
this pull request
Mar 3, 2017
The retires_on field was changed from a `:date` column to a `:datetime` which now requires the days(in seconds) be added to the time. - Depends on: ManageIQ/manageiq#14143 - This issue was introduced in PR ManageIQ/manageiq#11156 - https://bugzilla.redhat.com/show_bug.cgi?id=1427503 Signed-off-by: Sachin <psachin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally a part of #7471, splitting off the backend part for easier review/merge..
This changes the
retires_onfield from:dateto:datetime- the idea is that we will change the UI to let the user pick a specific point in time (including timezone) for the machine to retire, instead of a rather vague "that day +- 23.5 hours" (yay timezones!).(
retirement_last_warnalready IS a datetime)https://bugzilla.redhat.com/show_bug.cgi?id=1316632
UI changes are limited to adding time and time zone info to the messages and summaries...