Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edited catalog item type step with new functionality #631

Merged
merged 2 commits into from Jan 5, 2018

Conversation

dayleparker
Copy link
Contributor

@dayleparker dayleparker commented Jan 4, 2018

Hi Chris,

I think you've been working with catalogs lately... would you mind reviewing the changes I made and letting me know if the wording makes sense for the new functionality (described in ManageIQ/manageiq-ui-classic#2908), for docs BZ https://bugzilla.redhat.com/show_bug.cgi?id=1526554.

I also removed an old screencap from the step which I don't think was really needed, and a few other minor edits to the section. The previous version can be seen in step 4 in section 5.4.2 - https://access.redhat.com/documentation/en-us/red_hat_cloudforms/4.6-beta/html-single/provisioning_virtual_machines_and_hosts/#creating-a-catalog-item

Thanks for reviewing! Please let me know what you think.
Cheers,
Dayle

@Loicavenel
Copy link

@dayleparker I am not sure this "Only providers available to the appliance show in this list. The dialogs that appear will be filtered based on the selected type of provider." makes sense because some options like Orchestration are depending of multiple providers. And Ansible Playbook is not provider dependant but enable when a appliance role is active. May be something like: "This list will show only items related to providers available or Options activated like Ansible"

Updated catalog item type note to reflect new functionality
@miq-bot
Copy link
Member

miq-bot commented Jan 5, 2018

Checked commits dayleparker/manageiq_docs@14a579e~...22b5ae5 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@dayleparker
Copy link
Contributor Author

@Loicavenel Thanks for your feedback -- I wasn't sure about the wording myself but that makes more sense.
I've now edited it so it's: "This list only shows items related to providers available or options activated in the appliance (for example, Ansible Playbook is available as a Catalog Item Type option if the Embedded Ansible server role is enabled on the appliance)." I hope that's correct/easier to read now :)

@Loicavenel
Copy link

@dayleparker looks good.

@cbudz
Copy link
Contributor

cbudz commented Jan 5, 2018

Hey Dayle,

Everything looks good. Thanks for making those updates. Merging this request.

-Chris

@cbudz cbudz merged commit e202891 into ManageIQ:master Jan 5, 2018
@cbudz cbudz modified the milestone: Sprint 77 Ending Jan 15, 2018 Jan 15, 2018
@dayleparker dayleparker deleted the BZ#1526554-catalogproviders branch January 22, 2018 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants