UI changes to show options as disabled if those are not supported. #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR uses changes from backend in ManageIQ/manageiq#16559 to determine whether options in the drop down should be available or disabled based upon results returned in hash by backend method. https://bugzilla.redhat.com/show_bug.cgi?id=1515371
|
@h-kataria Tested looks good. |
|
Checked commit h-kataria@449896b with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 app/views/catalog/_st_form.html.haml |
|
Marking as |
|
@simaishi thanks Satoe . . . I somehow missed the pending label, but you can just backport once the other PR gets merged. |
|
This is currently breaking creation of new catalog items :(. Is the backend PR coming soon? :) |
|
@simaishi @himdel @dclarizio Core PR and all provider PRs have been merged and marked |
simaishi
pushed a commit
that referenced
this pull request
Dec 11, 2017
…sabled_catalog_item_types_in_drop_down UI changes to show options as disabled if those are not supported. (cherry picked from commit 19ecd2e) https://bugzilla.redhat.com/show_bug.cgi?id=1520613
|
Gaprindashvili backport details: |
h-kataria
deleted the
use_backend_method_to_show_disabled_catalog_item_types_in_drop_down
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses changes from backend in ManageIQ/manageiq#16559 to determine whether options in the drop down should be available or disabled based upon results returned in hash by backend method.
https://bugzilla.redhat.com/show_bug.cgi?id=1515371
before all options were always available:
after:
@mkanoor please test/review.
@dclarizio please review, this PR depends upon core PR ManageIQ/manageiq#16559