Remove util/vmdb-logger from appliance_console
#206
Conversation
This is never used by the appliance console, as it ends up just using
the default ruby logger for it's `default_logger`:
def self.default_logger
@default_logger ||= begin
require 'logger'
l = Logger.new(LOGFILE)
l.level = Logger::INFO
l
end
end
`default_logger` is also a attr_writer on the class, so if
`util/vmdb-logger` is wanted for the logger, a user can simply require
that when loading the bin, and then assign the logger themselves onto
the class variable.
|
Checked commit NickLaMuro@a242ba8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
I'm good with this, though I might argue the reverse approach that the default_logger should be changed to the vmdb-logger. @chessbyte Please review as you are extracting appliance_console, and this will collide with you. |
|
I'm ok with this. I don't think appliance_console should be required to use the vmdb_logger. |
|
Just tested this out. The console still logs successfully to I tested this on an appliance by configuring a database. |
|
@carbonin Thanks. Wasn't sure how to do this myself. But yes, kinda looked like it was just there for fun, or some where there was a setup that actually assigned the |
|
LGTM, then... letting @chessbyte coordinate the merge. |
This is never used by the appliance console, as it ends up just using the default ruby logger for it's
default_logger:default_loggeris also a attr_writer on the class, so ifutil/vmdb-loggeris wanted for the logger, a user can simply require that when loading the bin, and then assign the logger themselves onto the class variable.QA
Confirm that the appliance console still functions just fine with this removed.