Add :backup_type option to PostgresAdmin.restore #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows pre-fetching a backup_type when calling .restore, so no extra file type checking is done on the `opt[:local_file]` (which could be a streamed IO where that would break things down the line). This behaves as it had if this option isn't passed.
|
Checked commit NickLaMuro@0505809 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
carbonin
approved these changes
Nov 6, 2018
simaishi
pushed a commit
that referenced
this pull request
Nov 7, 2018
…h-in-postgres-admin-restore Add :backup_type option to PostgresAdmin.restore (cherry picked from commit b7d29b3)
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows pre-fetching a backup_type when calling
PostgresAdmin.restore, so no extra file type checking is done on theopt[:local_file](which could be a streamed IO where that would break things down the line).This behaves as it had if this option isn't passed.