Error handling for FindCatalogSourceByName #1044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FindCatalogSourceByName
was returning an empty catalog source object if the catalog source was not found instead of returningnil
i.e. (from debug logging)This was nullifying the openshift checks we have in place for deploying the strimzi operator https://github.com/ManageIQ/manageiq-pods/blob/master/manageiq-operator/internal/controller/manageiq_controller.go#L529
In addition it was found that the following error is thrown if performing a
client.Get()
call on a resource for which the CRDs are not installed (instead of throwing errors.IsNotFound()):This occurs when using plain k8s as the openshift CRDs (operators.coreos.com) are not installed
@miq-bot add_labels bug, quinteros/yes?
@miq-bot assign @bdunne
@miq-bot add_reviewer @Fryguy
Ref: #1043