Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go #914

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Upgrade Go #914

merged 3 commits into from
Feb 16, 2023

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Nov 8, 2022

Upgrade to go 1.20

@Fryguy
Copy link
Member

Fryguy commented Nov 8, 2022

If possible I'd like to delay until golang/go#54385 (GHSA-q856-gh5w-3vwg) is released (It might be part of 1.19.2, but hard to tell at the moment)

@bdunne
Copy link
Member Author

bdunne commented Nov 15, 2022

If possible I'd like to delay until golang/go#54385 (GHSA-q856-gh5w-3vwg) is released (It might be part of 1.19.2, but hard to tell at the moment)

Why wait? We can't set a minimum minor version, so we just require 1.19 and the mentioned change appears to be in the 1.19 branch.

@Fryguy
Copy link
Member

Fryguy commented Nov 22, 2022

Because our scanners are picking up on that one, and unless it's released, it's like shooting ourselves in the foot. If it wasn't a critical I wouldn't mind so much.

@Fryguy
Copy link
Member

Fryguy commented Nov 22, 2022

Ok, I doubled checked and this was backported in golang/go@2833550 which landed in 1.19.1. This is good to go, then (pun intended).

P.S. Spelunking go's gerrit and finding the exact commit that made it is such a pain. 😱

@Fryguy
Copy link
Member

Fryguy commented Dec 22, 2022

Marking oparin/no because we want to release soon and I don't want to introduce any stability

@bdunne bdunne changed the title Go 1.19 Upgrade Go Feb 16, 2023
@miq-bot
Copy link
Member

miq-bot commented Feb 16, 2023

Checked commits bdunne/manageiq-pods@cba694a~...a86b76d with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@Fryguy Fryguy merged commit e90ed54 into ManageIQ:master Feb 16, 2023
@bdunne bdunne deleted the go_1.19 branch February 22, 2023 22:53
@Fryguy
Copy link
Member

Fryguy commented Feb 28, 2023

Backported to petrosian in commit 983442e.

commit 983442ebcbec6077dba158b4509526ace360f748
Author: Jason Frey <fryguy9@gmail.com>
Date:   Thu Feb 16 16:31:00 2023 -0500

    Merge pull request #914 from bdunne/go_1.19
    
    Upgrade Go
    
    (cherry picked from commit e90ed5437cb70cc441e0dbae76d9cce81943d3f2)

Fryguy added a commit that referenced this pull request Feb 28, 2023
Upgrade Go

(cherry picked from commit e90ed54)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants