-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Go #914
Upgrade Go #914
Conversation
If possible I'd like to delay until golang/go#54385 (GHSA-q856-gh5w-3vwg) is released (It might be part of 1.19.2, but hard to tell at the moment) |
6a9acf9
to
e218619
Compare
Why wait? We can't set a minimum minor version, so we just require 1.19 and the mentioned change appears to be in the 1.19 branch. |
Because our scanners are picking up on that one, and unless it's released, it's like shooting ourselves in the foot. If it wasn't a critical I wouldn't mind so much. |
Ok, I doubled checked and this was backported in golang/go@2833550 which landed in 1.19.1. This is good to go, then (pun intended). P.S. Spelunking go's gerrit and finding the exact commit that made it is such a pain. 😱 |
Marking oparin/no because we want to release soon and I don't want to introduce any stability |
Checked commits bdunne/manageiq-pods@cba694a~...a86b76d with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint **
|
Backported to
|
Upgrade Go (cherry picked from commit e90ed54)
Upgrade to go 1.20