Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go 1.20 build issues #948

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Fix go 1.20 build issues #948

merged 1 commit into from
Mar 15, 2023

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Mar 15, 2023 •
edited
Loading

Followup to #914

Error:

[1/2] STEP 9/9: RUN CGO_ENABLED=0 go build -a -o manager main.go # k8s.io/kube-openapi/pkg/cached
/go/pkg/mod/k8s.io/kube-openapi@v0.0.0-20230308215209-15aac26d736a/pkg/cached/cache.go:242:16: undefined: atomic.Pointer # go.uber.org/multierr
/go/pkg/mod/go.uber.org/multierr@v1.10.0/error.go:224:20: undefined: atomic.Bool note: module requires Go 1.19
Error: error building at STEP "RUN CGO_ENABLED=0 go build -a -o manager main.go": error while running runtime: exit status 2 make: *** [Makefile:142: docker-build] Error 2

@bdunne
Fix go 1.20 build issues
7634d63 
Error:
[1/2] STEP 9/9: RUN CGO_ENABLED=0 go build -a -o manager main.go
# k8s.io/kube-openapi/pkg/cached
/go/pkg/mod/k8s.io/kube-openapi@v0.0.0-20230308215209-15aac26d736a/pkg/cached/cache.go:242:16: undefined: atomic.Pointer
# go.uber.org/multierr
/go/pkg/mod/go.uber.org/multierr@v1.10.0/error.go:224:20: undefined: atomic.Bool
note: module requires Go 1.19
Error: error building at STEP "RUN CGO_ENABLED=0 go build -a -o manager main.go": error while running runtime: exit status 2
make: *** [Makefile:142: docker-build] Error 2
@miq-bot
Copy link
Member

miq-bot commented Mar 15, 2023

Checked commit bdunne@7634d63 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@Fryguy Fryguy merged commit 0158358 into ManageIQ:master Mar 15, 2023
@Fryguy
Copy link
Member

Fryguy commented Mar 15, 2023

Backported to petrosian in commit 51e49aa.

commit 51e49aa584d3a002890b7014b326865695ea76f7
Author: Jason Frey <fryguy9@gmail.com>
Date:   Wed Mar 15 17:11:51 2023 -0400

    Merge pull request #948 from bdunne/go_1_20_followup
    
    Fix go 1.20 build issues
    
    (cherry picked from commit 01583581df61df374177b88258e7475026551eab)

Fryguy added a commit that referenced this pull request Mar 15, 2023
@Fryguy
Merge pull request #948 from bdunne/go_1_20_followup
51e49aa 
Fix go 1.20 build issues

(cherry picked from commit 0158358)
@bdunne bdunne deleted the go_1_20_followup branch March 15, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Fryguy Fryguy

Labels
bug petrosian/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bdunne @miq-bot @Fryguy