Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AWS instance_types #762

Closed
wants to merge 1 commit into from
Closed

Update AWS instance_types #762

wants to merge 1 commit into from

Conversation

miq-bot
Copy link
Member

@miq-bot miq-bot commented Apr 29, 2022

Update the saved list of AWS instance_types from https://instances.vantage.sh/instances.json

@Fryguy
Copy link
Member

Fryguy commented Apr 29, 2022 •
edited

@agrare As a follow-up I think we should set push-to-fork: miq-bot/manageiq-providers-amazon to avoid it creating branches in the main repo and also to avoid it running both push and pull_request.

The pushes will fail because any non-master branch that lives in the main repo is considered a release branch and it expects that Gemfile.lock.release is present,

@miq-bot
Copy link
Member Author

miq-bot commented Apr 29, 2022

Checked commit 671cc2c with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@agrare agrare mentioned this pull request Apr 29, 2022
Merged
@agrare agrare closed this Apr 29, 2022
@agrare agrare deleted the update_aws_instance_types branch April 29, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare Awaiting requested review from agrare agrare is a code owner

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miq-bot @Fryguy @agrare