Added necessary supports command #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonySchneider
requested review from
agrare,
Fryguy,
ereztheodorou,
erantzabari,
llivne and
gregoryb-at-ibm
as code owners
|
@miq-bot cross-repo-tests ManageIQ/manageiq-ui-classic#8279, ManageIQ/manageiq-api#1163 |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Jun 16, 2022
From Pull Request: ManageIQ/manageiq-providers-autosde#150
|
Checked commit Autosde@fbe501a with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint |
agrare
approved these changes
Jun 22, 2022
|
@TonySchneider can you add Specifically under this line: https://github.com/ManageIQ/manageiq/blob/master/app/models/physical_storage.rb#L37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the implementation of the new validation physical storage button. I need to add this 'supports :validate' command in order to use the 'supports' method in manageiq-api branch.
linked repos: