Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add physical server profile template #81
add physical server profile template #81
Changes from 7 commits
6dd1444
b581d60
8186a7e
116b226
b69b318
f22ddac
5622c90
1c9d9b1
aa04aa6
d1a5754
406a740
478e7d1
8404b3d
b614ae0
2ba1816
9eacc00
3f00570
d513094
f8b6305
324e40e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE this looks identical to the method in core except for the target_entity/ext_management_system bit. It would be nice to add a
refresh_target
method in core that defaults totarget_entity
if targeted_refresh is supported andext_management_system
otherwise which would allow you to override it and simply returnext_management_system
if you just want to do a full.Would be a good follow-up PR if you want to implement that in core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ManageIQ/manageiq#22254