Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a EmsRefreshWorkflow#refresh_target method #22254

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

agrare
Copy link
Member

@agrare agrare commented Nov 28, 2022

Allow provider subclasses to override the refresh_target method to control the refresh target.

Allow provider subclasses to override the refresh_target method to
control the refresh target.
@agrare
Copy link
Member Author

agrare commented Nov 28, 2022

@miq-bot
Copy link
Member

miq-bot commented Nov 28, 2022

Checked commit agrare@d55b337 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@Fryguy
Copy link
Member

Fryguy commented Nov 28, 2022

Can't the provider author just override target_entity? I'm confused what the extra method brings.

@agrare
Copy link
Member Author

agrare commented Nov 28, 2022

Can't the provider author just override target_entity? I'm confused what the extra method brings.

target_entity is used for other things in the Job, it was convenient to use that as the refresh target but if you don't want to do that overriding target_entity will prevent you from accessing that.

As an example, if you want to reconfigure a VM but for some reason your provider only supports Host targeted refresh. You want your target_entity to be the VM but you want to have your refresh_target to be the target_entity.host

@agrare agrare closed this Nov 28, 2022
@agrare agrare reopened this Nov 28, 2022
@Fryguy Fryguy self-assigned this Dec 7, 2022
@miq-bot
Copy link
Member

miq-bot commented Mar 13, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot miq-bot added the stale label Mar 13, 2023
@agrare agrare removed the stale label Mar 13, 2023
@agrare
Copy link
Member Author

agrare commented Mar 13, 2023

Still relevant, removing the stale label

@kbrock kbrock assigned kbrock and unassigned Fryguy Mar 13, 2023
@kbrock kbrock merged commit f00493d into ManageIQ:master Mar 13, 2023
@agrare agrare deleted the add_refresh_workflow_refresh_target branch March 13, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants