Hooking up Create Snapshot action to backend logic #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miyamotoh
force-pushed
the
snapshot-create
branch
2 times, most recently
from
1aaa44b
to
1c9e03f
Compare
agrare
reviewed
Jan 24, 2022
app/models/manageiq/providers/ibm_cloud/power_virtual_servers/cloud_manager/snapshot.rb
Outdated
Show resolved
Hide resolved
agrare
reviewed
Jan 24, 2022
app/models/manageiq/providers/ibm_cloud/power_virtual_servers/cloud_manager/vm/operations.rb
Outdated
Show resolved
Hide resolved
agrare
reviewed
Jan 24, 2022
app/models/manageiq/providers/ibm_cloud/power_virtual_servers/cloud_manager/vm/operations.rb
Outdated
Show resolved
Hide resolved
agrare
reviewed
Jan 24, 2022
app/models/manageiq/providers/ibm_cloud/power_virtual_servers/cloud_manager/vm.rb
Outdated
Show resolved
Hide resolved
9 tasks
miyamotoh
force-pushed
the
snapshot-create
branch
from
1c9e03f
to
e991698
Compare
Signed-off-by: Hiro Miyamoto <miyamotoh@us.ibm.com>
miyamotoh
force-pushed
the
snapshot-create
branch
from
e991698
to
eef0430
Compare
|
Looking good @miyamotoh |
miyamotoh
changed the title
agrare
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooking up "Create a new snapshot for this instance" (on a VM in PowerVS) menu action to the backend logic.
Also being added a little "name" validation logic that's drawn from API response;
Signed-off-by: Hiro Miyamoto miyamotoh@us.ibm.com