Adding "Management Console" access to open the VM's page on IBM Cloud

[miyamotoh]

Adding Access > Native Console action for a PowerVS VM. Very hacky (and thus WIP and likely change), but can open the VM's page on IBM Cloud.

Signed-off-by: Hiro Miyamoto miyamotoh@us.ibm.com

UI PR: ManageIQ/manageiq-ui-classic#8319

[agrare]

@miyamotoh are you trying to open the VM's remote console or the details/dashboard page?

[Fryguy]

Yeah, I don't like the word "console" for something that is not like a terminal console or a remote desktop to a VM. Think I had a similar problem in the original PR, but I can't think of a better term, and I hadn't thought of the potential terminology clash on the VM page.

EDIT: Meant to put this on the other PR, so moving it there.

[miyamotoh]

@agrare What I'm trying to open is a page on IBM Cloud (outside ManageIQ), showing the meta/details of the VM. See the screenshot in the other UI PR: ManageIQ/manageiq-ui-classic#8319

[agrare]

@miyamotoh yeah so the methods you're implementing are intended for "Remote Console" no the dashboard/details page.

For the VM dashboard you just need:

supports :native_console

def console_url
  "https://cloud.ibm.com/services/power-iaas/#{crn}/server/#{uid_ems}/?paneId=manage&crn=#{crn}"
end

I didn't realize until very recently that Ovirt Remote Console had methods also called native_console when we were doing the PowerVS "open the native provider dashboard" work.

[miyamotoh]

@agrare if that's all I need on the provider side, that's great, but what about the UI side? I wouldn't get the "Native Console" menu item nor any standalone button on the page. How does it get picked up by UI?

[agrare]

@miyamotoh correct but this is the provider PR 😉 I'll comment in the UI PR about what I think needs to happen there

[Fryguy]

Updated the OP to cross-link the PRs

[Fryguy]

As annoying as this is, CGI.escape should not be used because it doesn't handle things correctly...prefer ERB::Util.url_encode.

Aside, I'm tempted to put this in more_core_extensions so we don't have to think about this as much in the future.

[jaywcarman]

I recently used CGI.escape here. Sounds like it should be avoided in general?

[Fryguy]

Actually, I just realized you are using this for building the query part of the URL...in that case, I think you should use URI.encode_www_form:

Suggested change

	"https://cloud.ibm.com/services/power-iaas/#{crn}/server/#{uid_ems}/?paneId=manage&crn=#{crn}"
	params = URI.encode_www_form(:paneId => "manageiq", :crn => ext_management_system.pcloud_crn.values.join(":"))
	"https://cloud.ibm.com/services/power-iaas/#{crn}/server/#{uid_ems}/?#{params}"

[Fryguy]

Then as a optional followup, URL building should probably be done with the URI build method...something like:

Suggested change

	"https://cloud.ibm.com/services/power-iaas/#{crn}/server/#{uid_ems}/?paneId=manage&crn=#{crn}"
	params = URI.encode_www_form(:paneId => "manageiq", :crn => ext_management_system.pcloud_crn.values.join(":"))
	"https://cloud.ibm.com/services/power-iaas/#{crn}/server/#{uid_ems}/?#{params}"
	URI::HTTPS.build(:host => "cloud.ibm.com", :path => "/services/power-iaas/#{crn}/server/#{uid_ems}", :query => params)

[miyamotoh]

Feedback incorporated, force-push'd. PTAL.

[Fryguy]

Looks nice - just need to make sure the caller of this can handle a URI object or String being returned (they can just do .to_s)

[miq-bot]

Checked commit miyamotoh@165ee9f with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. ⭐