Processor pools support for PowerVS #443
Conversation
Update refresher VCR cassette to include new shared processor pool API calls.
Unfortunately, the PowerVS region we use for testing has limited capacity and setting too many affinity controls in the specs makes re-recording them a pain.
Only one cloud subnet is expected here - fixing the spec and removing the old TODO.
The "specific" VM used in the refresher spec was no longer a member of a placement group (see bed18fd). Using another VM in order to keep the placement_group lazy find spec coverage.
miyamotoh
requested review from
agrare,
jaywcarman,
iv1111,
blancett and
Fryguy
as code owners
| @@ -158,6 +158,10 @@ def assert_specific_vm | |||
| ) | |||
|
|
|||
| expect(vm.snapshots.first.total_size).to be > 0 | |||
|
|
|||
| instance_name = "test-instance-rhel-s922-shared-tier3" | |||
There was a problem hiding this comment.
Could we put test-instance-ibmi-s922-capped-tier1 in a resource_pool so that we don't have to check a second vm?
There was a problem hiding this comment.
I tried once, but if placement_group and spp_placement_group contradict each other, trying to put the VM on this or that host, then it'd fail, and it did fail on me trying to provision a VM with both specified. I figured that'd be just asking for a trouble at a later time, kinda relying on a luck.
miyamotoh
force-pushed
the
processor-pool-test
branch
from
a6230b1
to
793febc
Compare
Signed-off-by: Hiro Miyamoto <miyamotoh@us.ibm.com>
miyamotoh
force-pushed
the
processor-pool-test
branch
from
793febc
to
780f8ad
Compare
|
Some comments on commits miyamotoh/manageiq-providers-ibm_cloud@fdd3d4c~...780f8ad lib/tasks_private/power_virtual_servers.rake
|
|
Checked commits miyamotoh/manageiq-providers-ibm_cloud@fdd3d4c~...780f8ad with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
Aggregated PR with 6 commits from 3 developers, adding support for "shared processor pools" in PowerVS.
This supersedes #431 which has been gating;