Add shared processor pool field option to provision form

[alizapeikes]

Connected to ManageIQ/manageiq-providers-ibm_cloud#435

[miq-bot]

Checked commit alizapeikes@ac6d021 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 10 offenses detected

app/views/shared/views/_prov_dialog.html.haml

• ⚠️ - Line 433 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 433 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 433 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 433 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 433 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 433 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 433 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 433 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 433 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 433 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.

[jeffibm]

@alizapeikes , could you please add few screenshots and fix the lint errors...

[alizapeikes]

@alizapeikes , could you please add few screenshots and fix the lint errors...

@jeffibm I am not sure why I am getting those lint errors, I set it up exactly the same way as the code before and after?

[jeffibm]

@alizapeikes , could you please add few screenshots and fix the lint errors...

@jeffibm I am not sure why I am getting those lint errors, I set it up exactly the same way as the code before and after?

@alizapeikes, Yes. we can fix lint errors later as the lines are aligned with the previous line of codes.

[miyamotoh]

@jeffibm @agrare May I know what's holding up this PR? I tested this locally, and UI didn't break. I then applied the related PR for PowerVS also, and the depicted option showed up and got the new VM on the pool as intended.

I can follow up with the lint error, but it's actually all over the .haml file, not just the lines Aliza proposes to add...

[jeffibm]

This PR looks good.
Just waiting for @agrare to have one final look since the PR - ManageIQ/manageiq-providers-ibm_cloud#435 is not yet merged.

[miyamotoh]

Thanks, @jeffibm. I thought this was the pre-cursor for that ibm_cloud's 435 to work. FWIW, I did test this change alone and UI didn't break. Let's wait for @agrare. 🙂