-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh service catalog entities #276
Merged
Ladas
merged 9 commits into
ManageIQ:master
from
Ladas:refresh_service_catalog_entities
Aug 27, 2018
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4f97cdb
Add refresh of service catalog entities
Ladas 112d561
Remove broker and bindings
Ladas b061c45
Cleanup entities iterator and use it for every collection
Ladas f1fadc1
Memoize the collections for now
Ladas c6c98f4
Rename ServiceClass to ServiceOffering
Ladas e532bb9
Add service catalog STI subclasses
Ladas 5a8f576
Rename ServicePlan to ServiceParamatersSet
Ladas adebdbb
Add TODO for iterator, so we can properly add it later
Ladas a9937e2
Remove service instances for now
Ladas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
app/models/manageiq/providers/kubernetes/container_manager/service_offering.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
class ManageIQ::Providers::Kubernetes::ContainerManager::ServiceOffering < ::ServiceOffering | ||
end |
2 changes: 2 additions & 0 deletions
2
app/models/manageiq/providers/kubernetes/container_manager/service_parameters_set.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
class ManageIQ::Providers::Kubernetes::ContainerManager::ServiceParametersSet < ::ServiceParametersSet | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have too many ways to connect, what with
ems.connect(:service => ...)
, also I think supportingems.connect(:path => ...)
, and code somewhere I can't find now deriving path & version dynamically.Nothing wrong with this method however 👍. Just wish I had time to clean up some of the other ways...