Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supports terminate feature #164

Merged
merged 1 commit into from
May 29, 2020
Merged

Add supports terminate feature #164

merged 1 commit into from
May 29, 2020

Conversation

agrare
Copy link
Member

@agrare agrare commented May 28, 2020

@agrare agrare added the bug label May 28, 2020
@agrare agrare mentioned this pull request May 28, 2020
Merged
8 tasks
@agrare agrare changed the title Add supports terminate feature [WIP] Add supports terminate feature May 28, 2020
@miq-bot miq-bot added the wip label May 28, 2020
@agrare agrare force-pushed the add_supports_terminate_feature branch from 17aed1e to 44d86ac Compare May 29, 2020 12:26
@agrare agrare changed the title [WIP] Add supports terminate feature Add supports terminate feature May 29, 2020
@agrare agrare added jansa/yes? and removed wip labels May 29, 2020
@miq-bot
Copy link
Member

miq-bot commented May 29, 2020

Checked commit agrare@44d86ac with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍰

agrare added a commit to agrare/manageiq-cross_repo-tests that referenced this pull request May 29, 2020
@agrare
Test refactoring supports_terminate?
378a81b 
Testing:
ManageIQ/manageiq#20222
ManageIQ/manageiq-providers-amazon#626
ManageIQ/manageiq-providers-azure#397
ManageIQ/manageiq-providers-google#137
ManageIQ/manageiq-providers-kubevirt#164
ManageIQ/manageiq-providers-openstack#598
ManageIQ/manageiq-providers-ovirt#497
ManageIQ/manageiq-providers-vmware#584
@agrare agrare mentioned this pull request May 29, 2020
Closed
@chessbyte
Copy link
Member

Merging - Travis is green.

@chessbyte chessbyte merged commit 19a452d into ManageIQ:master May 29, 2020
@agrare agrare deleted the add_supports_terminate_feature branch May 29, 2020 16:30
simaishi pushed a commit that referenced this pull request May 29, 2020
@chessbyte @simaishi
Merge pull request #164 from agrare/add_supports_terminate_feature
d4e5e02 
Add supports terminate feature

(cherry picked from commit 19a452d)
@simaishi
Copy link

Jansa backport details:

$ git log -1
commit d4e5e0224dda60ebb6d9405423613005f4f1b3d3
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Fri May 29 12:28:45 2020 -0400

    Merge pull request #164 from agrare/add_supports_terminate_feature

    Add supports terminate feature

    (cherry picked from commit 19a452dd5c68eb73205cb8a2e8b76fea1f4ae1f3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

@masayag masayag Awaiting requested review from masayag

@pkliczewski pkliczewski Awaiting requested review from pkliczewski

Assignees

@chessbyte chessbyte

Labels
bug jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agrare @miq-bot @chessbyte @simaishi