Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse PhysicalDisks into PhysicalStorage #209

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Parse PhysicalDisks into PhysicalStorage #209

merged 1 commit into from
Sep 19, 2018

Conversation

EsdrasVP
Copy link
Member

@EsdrasVP EsdrasVP commented Jul 12, 2018 •
edited
Loading

@EsdrasVP EsdrasVP changed the title Parse StorageDrivers into PhysicalStorage [WIP] Parse StorageDrivers into PhysicalStorage Jul 12, 2018
@miq-bot miq-bot added the wip label Jul 12, 2018
@EsdrasVP EsdrasVP force-pushed the parse_storage_drive branch 2 times, most recently from e109478 to db2ccdc Compare July 12, 2018 19:55
@EsdrasVP EsdrasVP changed the title [WIP] Parse StorageDrivers into PhysicalStorage Parse StorageDrivers into PhysicalStorage Jul 12, 2018
@miq-bot miq-bot removed the wip label Jul 12, 2018
This was referenced Jul 13, 2018
Merged
Merged
Merged
@EsdrasVP EsdrasVP changed the title Parse StorageDrivers into PhysicalStorage Parse PhysicalDisks into PhysicalStorage Jul 26, 2018
@EsdrasVP EsdrasVP closed this Aug 13, 2018
@EsdrasVP EsdrasVP reopened this Aug 13, 2018
@douglasgabriel douglasgabriel self-assigned this Aug 13, 2018
@gtanzillo gtanzillo closed this Aug 27, 2018
@gtanzillo gtanzillo reopened this Aug 27, 2018
@EsdrasVP EsdrasVP changed the title Parse PhysicalDisks into PhysicalStorage [WIP] Parse PhysicalDisks into PhysicalStorage Sep 4, 2018
@miq-bot miq-bot added the wip label Sep 4, 2018
@EsdrasVP EsdrasVP force-pushed the parse_storage_drive branch 2 times, most recently from 63f7e11 to 299f126 Compare September 11, 2018 13:56
@miq-bot
Copy link
Member

miq-bot commented Sep 13, 2018

This pull request is not mergeable. Please rebase and repush.

@EsdrasVP EsdrasVP force-pushed the parse_storage_drive branch 2 times, most recently from 11b0d38 to 27884b0 Compare September 17, 2018 14:22
@EsdrasVP EsdrasVP changed the title [WIP] Parse PhysicalDisks into PhysicalStorage Parse PhysicalDisks into PhysicalStorage Sep 17, 2018
@EsdrasVP EsdrasVP force-pushed the parse_storage_drive branch 2 times, most recently from 9498da3 to d1f5967 Compare September 19, 2018 12:18
@EsdrasVP EsdrasVP force-pushed the parse_storage_drive branch 4 times, most recently from 6ce186e to 92e795a Compare September 19, 2018 13:42
@miq-bot
Copy link
Member

miq-bot commented Sep 19, 2018

Checked commit EsdrasVP@966984f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@felipedf felipedf mentioned this pull request Sep 19, 2018
Merged
douglasgabriel
douglasgabriel approved these changes Sep 19, 2018
View reviewed changes
Copy link
Member

@douglasgabriel douglasgabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@douglasgabriel douglasgabriel merged commit 7be0ac1 into ManageIQ:master Sep 19, 2018
@agrare agrare added this to the Sprint 95 Ending Sep 24, 2018 milestone Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douglasgabriel douglasgabriel douglasgabriel approved these changes

Assignees

@douglasgabriel douglasgabriel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EsdrasVP @miq-bot @douglasgabriel @gtanzillo @agrare