safe_call should catch Fog::Errors::NotFound

[mansam]

Some fog calls raise subclasses of Fog::Errors::NotFound instead of Excon::Errors::NotFound. This change allows safe_call (and by extension safe_list) to handle those cases.

This should fix issues with deleted flavors crashing refresh despite the catch, since list_tenants_with_flavor_access throws Fog::Compute::OpenStack::NotFound.

[miq-bot]

Checked commit mansam@a406f66 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

[aufi]

Nice catch Sam 💯 Looks good to me, merging!

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit c84263978a31f77b58a50441951ff4248d7231f8
Author: Marek Aufart <aufi.cz@gmail.com>
Date:   Wed Nov 15 09:14:36 2017 +0100

    Merge pull request #156 from mansam/safe_call_catch_fog_not_found_errors
    
    safe_call should catch Fog::Errors::NotFound
    (cherry picked from commit 84121cb85efa6d20d1121308529036914222484a)

[simaishi]

@mansam Please add BZ link.

[mansam]

https://bugzilla.redhat.com/show_bug.cgi?id=1479978
https://bugzilla.redhat.com/show_bug.cgi?id=1460683

[simaishi]

@mansam 2 BZs you referenced are already CLOSED/ERRATA for Fine branch. I'd need a non-closed BZ so it's clear what this particular PR will be fixing for a particular build...

[mansam]

@simaishi That makes sense, this PR was a response to comments made on the BZ after it was already closed and I suppose I should have opened a new BZ for the fix. Coincidentally, a new fine BZ was just opened that I think should be fixed by this as well: https://bugzilla.redhat.com/show_bug.cgi?id=1552135

[simaishi]

Fine backport (to manageiq repo) details:

$ git log -1
commit 1c3fe51d3473674096a5da8c37a7852dbfc41327
Author: Marek Aufart <aufi.cz@gmail.com>
Date:   Wed Nov 15 09:14:36 2017 +0100

    Merge pull request #156 from mansam/safe_call_catch_fog_not_found_errors
    
    safe_call should catch Fog::Errors::NotFound
    (cherry picked from commit 84121cb85efa6d20d1121308529036914222484a)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552135