Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow all networks to be attached directly to a VM #27

Merged
merged 1 commit into from
May 4, 2017
Merged

Allow all networks to be attached directly to a VM #27

merged 1 commit into from
May 4, 2017

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Apr 27, 2017

Allow all networks to be attached directly to a VM

Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1431370

@Ladas
Copy link
Contributor Author

Ladas commented Apr 27, 2017

@miq-bot assign @tzumainn

@Ladas Ladas mentioned this pull request Apr 27, 2017
Merged
@Ladas Ladas force-pushed the allow_external_network_to_be_attached_directly_to_a_vm branch from d2033ad to 57114d7 Compare April 27, 2017 13:37
@miq-bot
Copy link
Member

miq-bot commented Apr 27, 2017

Checked commit Ladas@57114d7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
6 files checked, 0 offenses detected
Everything looks fine. 👍

@tzumainn
Copy link
Contributor

👍 tested, works as advertised in conjunction with ManageIQ/manageiq#14920

@Ladas Ladas mentioned this pull request May 4, 2017
Closed
1 task
@tzumainn tzumainn closed this May 4, 2017
@tzumainn tzumainn reopened this May 4, 2017
@tzumainn tzumainn merged commit 01fac37 into ManageIQ:master May 4, 2017
@alexander-demicev alexander-demicev mentioned this pull request Feb 7, 2018
Closed
@alexander-demicev
Copy link

@miq-bot add_label fine/yes

@alexander-demicev
Copy link

Depends on ManageIQ/manageiq#14920
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1507509

@simaishi simaishi removed the fine/no label Feb 28, 2018
@simaishi
Copy link
Contributor

simaishi commented Apr 9, 2018 •
edited
Loading

Fine backport (to manageiq repo) details:

$ git log -1
commit 15fa1b7c2ed351c5b7339ff0162690f6da0b5ca3
Author: tzumainn <tzumainn@redhat.com>
Date:   Thu May 4 09:43:09 2017 -0400

    Merge pull request #27 from Ladas/allow_external_network_to_be_attached_directly_to_a_vm
    
    Allow all networks to be attached directly to a VM
    (cherry picked from commit 01fac377005c6ce492b9dbbee6dc2533076f3b19)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tzumainn tzumainn

Labels
fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ladas @miq-bot @tzumainn @alexander-demicev @simaishi