Make events_backread switchable #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenStack should expect timestamps in UTC. However some production environments might work in different way. The safest way fix seems to be extend event_backread feature with possibility to turn it off. Event backread can be now turned off by setting :event_backread_seconds settings option to number less than 1, e.g. 0. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1734338
|
Checked commit aufi@d854ee9 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@Ladas There was problem with intepretation time with timezones between CF and OSP, disabling backread avoids timestamp manipulation on CF side. |
|
@aufi |
simaishi
pushed a commit
that referenced
this pull request
Aug 12, 2019
Make events_backread switchable (cherry picked from commit a600714) https://bugzilla.redhat.com/show_bug.cgi?id=1734338
|
Ivanchuk backport details: |
simaishi
pushed a commit
that referenced
this pull request
Aug 14, 2019
Make events_backread switchable (cherry picked from commit a600714) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1740767
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenStack should expect timestamps in UTC. However some production environments
might work in different way. The safest way fix seems to be extend event_backread
feature with possibility to turn it off.
Event backread can be now turned off by setting :event_backread_seconds
settings option to number less than 1, e.g. 0.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1734338