Remove v3 api form SSA #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the usage of the ovirt gem and version 3 api from the SSA Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1535782
|
Checked commit borod108@de7eb0e with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 app/models/manageiq/providers/redhat/inventory/collector.rb
|
|
@agrare what say you? |
agrare
reviewed
Jul 29, 2019
| @@ -151,7 +151,7 @@ def connect_to_ems(ost) | |||
| $log.info "#{log_header}: Connecting to [#{ems_display_text}] for VM:[#{@vm_cfg_file}]" | |||
|
|
|||
| begin | |||
| ost.miqRhevm = ext_management_system.rhevm_inventory(:force_v3 => true) | |||
| ost.miqRhevm = ManageIQ::Providers::Redhat::Inventory::Collector.new(ext_management_system, nil) | |||
There was a problem hiding this comment.
Not for this, but I think we should make the Collector initializer initialize(manager, target = nil) in core if it isn't required.
|
@borod108 these both say they depend on each other, if I had to guess I'd say this has to be merged first is that right? |
agrare
approved these changes
Aug 14, 2019
simaishi
pushed a commit
that referenced
this pull request
Aug 21, 2019
Remove v3 api form SSA (cherry picked from commit 343edb5) https://bugzilla.redhat.com/show_bug.cgi?id=1535782
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the usage of the ovirt gem and version 3 api from the SSA
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1535782
Depends on: ManageIQ/manageiq-smartstate#98