Remove v3 api form SSA

[borod108]

Remove the usage of the ovirt gem and version 3 api from the SSA

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1535782

Depends on: ManageIQ/manageiq-providers-ovirt#394

[borod108]

@roliveri is this ok?

[miq-bot]

Checked commit borod108@b0b5c73 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

lib/MiqVm/MiqVm.rb

• ❗ - Line 45, Col 7 - Naming/VariableName - Use snake_case for variable names.

[borod108]

@miq-bot add_label bug
@miq-bot add_label ivanchuk/yes

[miq-bot]

@borod108 Cannot apply the following label because they are not recognized: ivanchuk/yes

[agrare]

@miq-bot assign @roliveri

[jerryk55]

I'm not sure this was looked at with regard to other interactions inside the SSA gem. For instance, rhevmVm.disks was removed but it is used in the VmConfig code.

[roliveri]

@borod108,
as per Jerry's comment, are there still issues with the VmConfig code?

[borod108]

@jerryk55 can you suggest how I will find all those places? Currently with this code smartstate analysis works, how should I find all the places to change?

[agrare]

@borod108 could you maintain the same interface but use the v3 api instead? That should fix the issue of having to find every caller

[borod108]

@agrare I could, we talked about it with Martin - it just does not seem to be a good solution. Also - if we fix it properly then the knowledge of how this thing actually works will spread to us as well and we will be able to fix things in the future and not keep putting bandages on this.

[borod108]

@agrare @roliveri @jerryk55 so how should we proceed?
Can you point me to what else I should change?
I mean it runs on my env and there are no tests for this part that fail so I am not sure what to do here...

[roliveri]

@jerryk55 Can you provide a pointer to where it's used in the VmConfig code?

[jerryk55]

Yeah let me look it up again. Hopefully I'm not mistaken. Or maybe its better if I am. More to come....

[jerryk55]

I believe I was mistaken. There is a reference to rhevmVm.disks in VMconfig - not rhevmVm.attributes[:disks] - I misread the code. So I remove my objection to this.

[roliveri]

@borod108 Will release a new version of the manageiq-smartstate GEM and let you know the version.

[roliveri]

@borod108 released version 0.3.0 of the manageiq-smartstate GEM.