Move VIM_SELECTOR_SPEC out of the base EmsRefresh #20
Conversation
agrare
force-pushed
the
refactor_vim_selector_spec
branch
from
d2f223e
to
601074a
Compare
|
@durandom this is pluggable-providers/provider-extraction territory, can you review? |
agrare
force-pushed
the
refactor_vim_selector_spec
branch
from
601074a
to
f2f56be
Compare
|
Looks like a move in the right direction :) How about moving the whole Isnt this whole VimBroker construct really Vmware specific? Maybe you can chat with @jrafanie how we can move |
|
@durandom that's exactly what I'm planning on 😄 right now VcUpdates still needs to be in EmsRefresh so I can't just move it out (yet) but that's coming soon |
| @@ -15,7 +15,7 @@ def self.init_console(use_vim_broker = false) | |||
| def provider.use_vim_broker?; @__use_vim_broker; end | |||
| klass = use_vim_broker ? MiqVimBroker : MiqVimInventory | |||
| klass.cacheScope = :cache_scope_ems_refresh | |||
| klass.setSelector(EmsRefresh::VcUpdates::VIM_SELECTOR_SPEC) | |||
| klass.setSelector(ManageIQ::Providers::Vmware::InfraManager::SelectorSpec::VIM_SELECTOR_SPEC) | |||
There was a problem hiding this comment.
you could use parent to avoid the FQN
klass.setSelector(parent::SelectorSpec::VIM_SELECTOR_SPEC)
but it looks like we seldom use this...
There was a problem hiding this comment.
Good point, yeah this is just used when running EmsRefresh on the rails console
If ManageIQ/manageiq#14205 looks good to you too then go for it :) |
|
Yeah, the corresponding PR looks great too |
|
Thanks @durandom ! The rest of |
The
VIM_SELECTOR_SPECis used to filter properties that we care about from the VMware provider to reduce memory usage. It is a very VMware specific construct but was inEmsRefresh::VcUpdatesin the main manageiq repository.This moves the selection spec out of
EmsRefreshunderManageIQ::Providers::Vmware::InfraManager::VimSelectorSpec