Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RbVmomi to version 2.3 #529

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Feb 14, 2020

Update to the most recent version of RbVmomi

Depends on: ManageIQ/vmware_web_service#75, vmware-archive/rbvmomi#176

@agrare agrare requested a review from Fryguy as a code owner February 14, 2020 18:51
@chessbyte chessbyte closed this Feb 15, 2020
@chessbyte chessbyte reopened this Feb 15, 2020
@agrare
Copy link
Member Author

agrare commented Feb 15, 2020

A number of vmodl types are wrong in rbvmomi in the newer versions, put in vmware-archive/rbvmomi#176 to address these

@agrare
Copy link
Member Author

agrare commented Feb 15, 2020

👍 cross repo tests with vmware-archive/rbvmomi#176 applied are green: ManageIQ/manageiq-cross_repo-tests#70

@agrare agrare force-pushed the update_rbvmomi_gem branch 2 times, most recently from 06a3a4d to 96e7e47 Compare February 24, 2020 16:24
@agrare agrare changed the title Bump RbVmomi to version 2.3.0 [WIP] Bump RbVmomi to version 2.3.0 Feb 24, 2020
@agrare
Copy link
Member Author

agrare commented Feb 24, 2020

WIP pending vmware-archive/rbvmomi#176

@miq-bot miq-bot added the wip label Feb 24, 2020
@agrare
Copy link
Member Author

agrare commented Mar 24, 2020

Taking out of WIP now that https://rubygems.org/gems/rbvmomi/versions/2.3.1 has been released with vmware-archive/rbvmomi#176

@agrare agrare changed the title [WIP] Bump RbVmomi to version 2.3.0 Bump RbVmomi to version 2.3 Mar 24, 2020
@agrare agrare removed the wip label Mar 24, 2020
@miq-bot
Copy link
Member

miq-bot commented Mar 24, 2020

Checked commit agrare@84c0903 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@gtanzillo gtanzillo merged commit 18281cc into ManageIQ:master Mar 24, 2020
@agrare agrare deleted the update_rbvmomi_gem branch March 24, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants