Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency on the kafka package #91

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Sep 22, 2020

No description provided.

@bdunne bdunne added enhancement New feature or request wip dependencies labels Sep 22, 2020
@bdunne
Copy link
Member Author

bdunne commented Sep 22, 2020

Marking as WIP until the appliance console work is ready to go.

@miq-bot
Copy link
Member

miq-bot commented Sep 22, 2020

Checked commit bdunne@46a0414 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@bdunne bdunne changed the title [WIP] Add dependency on the kafka package Add dependency on the kafka package Nov 18, 2020
@bdunne
Copy link
Member Author

bdunne commented Nov 18, 2020

Un-WIP since the appliance console work is close to done. kasparov/no since this is targeted for lasker.

@simaishi
Copy link
Contributor

simaishi commented Dec 3, 2020

@bdunne I see only x86_64 rpm built, so this will break pcc64le. I think we need to either build ppc64le rpm or put %ifarch x86_64 around it.

@bdunne
Copy link
Member Author

bdunne commented Mar 30, 2021

@simaishi @Fryguy I added the Kafka PPC RPM, so we're ready to merge this.

@Fryguy Fryguy merged commit 8c799ac into ManageIQ:master Mar 30, 2021
@bdunne bdunne deleted the add_kafka branch March 30, 2021 14:20
@Fryguy
Copy link
Member

Fryguy commented Sep 15, 2021

Backported to morphy in commit abd031d.

commit abd031d9e3f730ebc7dee58b0eff0c1e30d4c6c9
Author: Jason Frey <fryguy9@gmail.com>
Date:   Tue Mar 30 09:41:26 2021 -0400

    Merge pull request #91 from bdunne/add_kafka
    
    Add dependency on the kafka package
    
    (cherry picked from commit 8c799ac75bb743d1192fa54d8fd3cfba5fcfb472)

Fryguy added a commit that referenced this pull request Sep 15, 2021
Add dependency on the kafka package

(cherry picked from commit 8c799ac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants