Merge pull request #6156 from rvsia/timelines-title

Timelines title
ManageIQ · Sep 9, 2019 · 2c4554a · 2c4554a
2 parents 66379ac + 17b8b19
commit 2c4554a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/app/controllers/mixins/more_show_actions.rb b/app/controllers/mixins/more_show_actions.rb
@@ -7,7 +7,7 @@ def show_timeline
       @lastaction = "show_timeline"
       @timeline = @timeline_filter = true
       tl_build_timeline # Create the timeline report
-      drop_breadcrumb(:name => _("Timelines"),
+      drop_breadcrumb(:name => _("Timelines for %{table} \"%{name}\"") % {:table => ui_lookup(:table => controller_name), :name => @record.name},
                       :url  => "/#{controller_name}/show/#{@record.id}" \
                                "?refresh=n&display=timeline")
     end

diff --git a/app/views/layouts/_tl_show.html.haml b/app/views/layouts/_tl_show.html.haml
@@ -3,6 +3,8 @@
   ManageIQ.calendar.calDateFrom = new Date(#{@tl_options.date.start});
   ManageIQ.calendar.calDateTo = new Date(#{@tl_options.date.end});
 
+%h1
+  = @title
 = render :partial => "layouts/flash_msg"
 = render :partial => "layouts/tl_options"
 = render :partial => 'layouts/tl_detail'

diff --git a/spec/controllers/ems_infra_controller_spec.rb b/spec/controllers/ems_infra_controller_spec.rb
@@ -325,6 +325,11 @@
         expect(ApplicationHelper::Toolbar::TimelineCenter).to receive(:definition).and_call_original
         subject
       end
+
+      it "contains timelines title" do
+        subject
+        expect(response.body).to include("Timelines for #{ui_lookup(:table => controller.controller_name)} &quot;#{@ems.name}&quot;")
+      end
     end
 
     context "render listnav partial" do