Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timelines title #6156

Merged
merged 1 commit into from Sep 9, 2019
Merged

Timelines title #6156

merged 1 commit into from Sep 9, 2019

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Sep 5, 2019

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1732517

Steps to Reproduce:

  1. Add infra provider
  2. Navigate to Timelines page of the infra provider

Actual results:
No title on the page

Expected results:
Should be a title on the page

Description

  • adds @title to timeline template
  • sets specific title to be consistent with timelines in VM/instance controllers

Before

image

After

image

@miq-bot add_label bug, ivanchuk/yes, hammer/no, changelog/yes

@miq-bot
Copy link
Member

miq-bot commented Sep 5, 2019

Checked commit rvsia@17b8b19 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@martinpovolny martinpovolny self-assigned this Sep 9, 2019
@martinpovolny martinpovolny added this to the Sprint 120 Ending Sep 16, 2019 milestone Sep 9, 2019
@martinpovolny martinpovolny merged commit 2c4554a into ManageIQ:master Sep 9, 2019
@rvsia rvsia deleted the timelines-title branch September 17, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants