Skip to content

Commit

Permalink
Fixes missing toolbar button for tagging from a configured system sum…
Browse files Browse the repository at this point in the history
…mary page in the ansible provider accordion

Fixed mixed lifecycle toolbars for foreman and automation
  • Loading branch information
lgalis committed Nov 21, 2017
1 parent ccf89fc commit 8e85612
Show file tree
Hide file tree
Showing 9 changed files with 30 additions and 11 deletions.
2 changes: 1 addition & 1 deletion app/controllers/automation_manager_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def class_for_provider_node
case nodes.first
when "root" then ManageIQ::Providers::AnsibleTower::AutomationManager
when "at", "e" then ManageIQ::Providers::AutomationManager::InventoryRootGroup
when "f" then ManageIQ::Providers::AnsibleTower::AutomationManager::ConfiguredSystem
when "f", "cs" then ManageIQ::Providers::AnsibleTower::AutomationManager::ConfiguredSystem
when "xx" then
case nodes.second
when "at" then ManageIQ::Providers::AnsibleTower::AutomationManager
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module ApplicationHelper::Toolbar::ConfiguredSystem::AutomationPolicyMixin
module ApplicationHelper::Toolbar::ConfiguredSystem::Automation::PolicyMixin
def self.included(included_class)
included_class.button_group('automation_manager_policy', [
included_class.select(
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module ApplicationHelper::Toolbar::ConfiguredSystem::LifecycleMixin
module ApplicationHelper::Toolbar::ConfiguredSystem::Foreman::LifecycleMixin
def self.included(included_class)
included_class.button_group('provider_foreman_lifecycle', [
included_class.select(
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module ApplicationHelper::Toolbar::ConfiguredSystem::PolicyMixin
module ApplicationHelper::Toolbar::ConfiguredSystem::Foreman::PolicyMixin
def self.included(included_class)
included_class.button_group('provider_foreman_policy', [
included_class.select(
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
class ApplicationHelper::Toolbar::ConfiguredSystemsAnsibleCenter < ApplicationHelper::Toolbar::Basic
include ApplicationHelper::Toolbar::ConfiguredSystem::PolicyMixin
include ApplicationHelper::Toolbar::ConfiguredSystem::Automation::PolicyMixin
end
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
class ApplicationHelper::Toolbar::ConfiguredSystemsCenter < ApplicationHelper::Toolbar::Basic
include ApplicationHelper::Toolbar::ConfiguredSystem::LifecycleMixin
include ApplicationHelper::Toolbar::ConfiguredSystem::PolicyMixin
include ApplicationHelper::Toolbar::ConfiguredSystem::Foreman::LifecycleMixin
include ApplicationHelper::Toolbar::ConfiguredSystem::Foreman::PolicyMixin
end
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
class ApplicationHelper::Toolbar::UnassignedProfilesGroupCenter < ApplicationHelper::Toolbar::Basic
include ApplicationHelper::Toolbar::ConfiguredSystem::LifecycleMixin
include ApplicationHelper::Toolbar::ConfiguredSystem::PolicyMixin
include ApplicationHelper::Toolbar::ConfiguredSystem::Foreman::LifecycleMixin
include ApplicationHelper::Toolbar::ConfiguredSystem::Foreman::PolicyMixin
end
Original file line number Diff line number Diff line change
@@ -1,3 +1,22 @@
class ApplicationHelper::Toolbar::XAutomationManagerAnsibleTowerConfiguredSystemCenter < ApplicationHelper::Toolbar::Basic
include ApplicationHelper::Toolbar::ConfiguredSystem::AutomationPolicyMixin
button_group('record_summary', [
select(
:automation_manager_policy_choice,
'fa fa-shield fa-lg',
t = N_('Policy'),
t,
:enabled => true,
:items => [
button(
:configured_system_tag,
'pficon pficon-edit fa-lg',
N_('Edit Tags for this Configured System'),
N_('Edit Tags'),
:url => "tagging",
:url_parms => "main_div",
:send_checked => true,
:enabled => true),
]
),
])
end
2 changes: 1 addition & 1 deletion app/helpers/application_helper/toolbar_chooser.rb
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@ def configuration_manager_providers_tree_center_tb(nodes)
when "f" then inventory_group_center_tb
when "xx" then
case nodes.last
when "f" then "configured_systems_ansible_center_tb"
when "f" then "configured_systems_center_tb"
when "cp" then "unassigned_profiles_group_center_tb"
else "configuration_manager_providers_center_tb"
end
Expand Down

0 comments on commit 8e85612

Please sign in to comment.