Merge pull request #2700 from mkanoor/add_icons_for_methods

Icons to discern automate method types

app/assets/stylesheets/icon_customizations.scss

@@ -59,4 +59,8 @@ opacity:0.6;
   color: #ec7a08; //pf-orange-400
 }
 
+.fa-ruby {
+  @extend .fa, .fa-lg, .fa-diamond;
+  color: red;
+}
 /*end icon class customizations*/

app/decorators/miq_ae_method_decorator.rb

@@ -1,5 +1,18 @@
 class MiqAeMethodDecorator < MiqDecorator
-  def self.fonticon
-    'ff ff-method'
+  def fileicon
+    "svg/vendor-ansible.svg" if location == 'playbook'
+  end
+
+  def fonticon
+    case location
+    when "inline"
+      'fa-ruby'
+    when "expression"
+      'fa fa-search'
+    when "playbook"
+      nil
+    else
+      'ff ff-method'
+    end
   end
 end

app/presenters/tree_node/miq_ae_method.rb

@@ -1,4 +1,5 @@
 module TreeNode
   class MiqAeMethod < MiqAeNode
+    set_attribute(:image) { @object.try(:decorate).try(:fileicon) }
   end
 end

app/views/miq_ae_class/_class_methods.html.haml

@@ -16,7 +16,10 @@
               %td.table-view-pf-select.noclick
                 %input{:type => 'checkbox', :value => cls_cid}
               %td.table-view-pf-select
-                %i{:class => record.decorate.fonticon}
+                - if record.decorate.try(:fileicon)
+                  %img{:src => ActionController::Base.helpers.image_path(record.decorate.fileicon)}
+                - else
+                  %i{:class => record.decorate.fonticon}
               %td
                 = record_name(record)
       :javascript

spec/presenters/tree_node/miq_ae_method_spec.rb

@@ -5,6 +5,6 @@
   let(:object) { FactoryGirl.create(:miq_ae_method, :scope => :class, :language => :ruby, :location => :inline) }
 
   include_examples 'TreeNode::Node#key prefix', 'aem-'
-  include_examples 'TreeNode::Node#icon', 'ff ff-method'
+  include_examples 'TreeNode::Node#icon', 'fa-ruby'
   include_examples 'TreeNode::Node#tooltip prefix', 'Automate Method'
 end