Icons to discern automate method types #2700
Conversation
|
@skateman @epwinchell |
| when "playbook" | ||
| 'fa fa-font' | ||
| when "inline" | ||
| 'fa fa-diamond' |
There was a problem hiding this comment.
@epwinchell This diamond is for ruby method so we might need it to be colored red.
There was a problem hiding this comment.
@epwinchell let's create a new icon class called fa-diamond-red, what do you think?
|
@mkanoor are you sure about the fonticon-only approach? I'd like the ansible logo svg and a ruby gem logo more. But maybe @epwinchell will say differently... |
|
@mkanoor Looks good |
There are different automate method types like * Inline (ruby) * Playbook (Ansible) * Expression (MiqExpression/Search) * Builtin (Macros) In the UI we can't discren the method type if they all have the same icons, this PR adds different icons for different method types
mkanoor
force-pushed
the
add_icons_for_methods
branch
from
d7e586c
to
dbd6aed
Compare
|
@skateman @epwinchell |
|
Checked commit mkanoor@dbd6aed with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Icons to discern automate method types (cherry picked from commit fdb8f57)
|
Gaprindashvili backport details: |
There are different automate method types like
In the Automate Explorer we can't discern the method type if they all have the same icons, this PR adds different icons for different method types.
Before, my_method is an Ansible method but the icon doesn't give you a hint.
After the my_method has ansible logo to indicate that its a Ansible Playbook method, we dont have to open the method to figure out its type.