Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links to parent provider from Job summary page #1127

Merged
merged 5 commits into from
Apr 24, 2017
Merged

Fix links to parent provider from Job summary page #1127

merged 5 commits into from
Apr 24, 2017

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Apr 24, 2017 •
edited
Loading

Fix links to parent provider from Job summary page

https://bugzilla.redhat.com/show_bug.cgi?id=1435280

@miq-bot miq-bot added the wip label Apr 24, 2017
@lgalis lgalis force-pushed the fix_link_to_parent_tower_provider_in_job_summary branch from 815f842 to 31bdcfe Compare April 24, 2017 12:50
@lgalis lgalis force-pushed the fix_link_to_parent_tower_provider_in_job_summary branch from 31bdcfe to 59aeec0 Compare April 24, 2017 13:08
@lgalis lgalis changed the title [WIP] Fix links to parent provider from Job summary page Fix links to parent provider from Job summary page Apr 24, 2017
@lgalis
Copy link
Contributor Author

lgalis commented Apr 24, 2017

@miq-bot add_label bug, fine/yes, euwe/no

@lgalis
Merge branch 'master' of github.com:ManageIQ/manageiq-ui-classic into…
4f2e1bf 
… fix_link_to_parent_tower_provider_in_job_summary
@miq-bot
Copy link
Member

miq-bot commented Apr 24, 2017

Checked commits lgalis/manageiq-ui-classic@59aeec0~...4f2e1bf with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. 🏆

@lgalis
Copy link
Contributor Author

lgalis commented Apr 24, 2017 •
edited
Loading

@dclarizio or @h-kataria - please review

@lgalis lgalis closed this Apr 24, 2017
@lgalis lgalis reopened this Apr 24, 2017
@h-kataria
Copy link
Contributor

looks good.

@h-kataria h-kataria added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 24, 2017
@h-kataria h-kataria merged commit cb562dd into ManageIQ:master Apr 24, 2017
simaishi pushed a commit that referenced this pull request Apr 24, 2017
@h-kataria @simaishi
Merge pull request #1127 from lgalis/fix_link_to_parent_tower_provide…
d5eacd2 
…r_in_job_summary

Fix links to parent provider from Job summary page
(cherry picked from commit cb562dd)

https://bugzilla.redhat.com/show_bug.cgi?id=1442767
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit d5eacd28127359d7bd220672d97748ca5807612e
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Mon Apr 24 16:35:03 2017 -0400

    Merge pull request #1127 from lgalis/fix_link_to_parent_tower_provider_in_job_summary
    
    Fix links to parent provider from Job summary page
    (cherry picked from commit cb562dd482d3ed6bb6f2f25f54d9d34e79e4c712)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1442767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
automation/ansible tower bug fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lgalis @miq-bot @h-kataria @simaishi @dclarizio